[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-20 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG95423c7c990d: [clang][driver] Treat -flto=[auto,jobserver] as -flto (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https:/

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-20 Thread Steven Wu via Phabricator via cfe-commits
steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 ___ cfe-commits mailing list cfe-com

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 346737. tbaeder added a comment. Use `hasFlag()` instead of `hasArg()` in Driver.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 346635. tbaeder added a comment. Thanks for the feedback, I think this should work better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 346634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/lto.c Index:

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-18 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. I don't think current implementation is the best idea. I think is better to make the gcc compatible LTO value to be a clang Driver only option, give them an option name, and handle them separately in driver to invoke correct fullLTO cc1 command, so that: - The value

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 346058. Herald added subscribers: steven_wu, hiraditya. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Frontend/Compi

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 345763. tbaeder added a comment. On second thought, rather only handle `=auto` and `=jobserver` and don't warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.t

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added a reviewer: tejohnson. Herald added subscribers: dang, inglorion. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behavior was introduced in https://github.com/llvm/llvm-proj