This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ce02ea8c941: [OpenMP] Add Module metadata for OpenMP
compilation (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
jhuber6 updated this revision to Diff 354368.
jhuber6 added a comment.
Removing runtime check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102361/new/
https://reviews.llvm.org/D102361
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/Ope
jhuber6 added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:709
+getModule().addModuleFlag(llvm::Module::Max, "openmp-device",
+ LangOpts.OpenMP);
+
jdoerfert wrote:
> Why do we need `OpenMPRuntime` in the condi
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:709
+getModule().addModuleFlag(llvm::Module::Max, "openmp-device",
+ LangOpts.OpenMP);
+
Why do we need `OpenMPRuntime` in the conditional?
Reposit
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102361/new/
https://reviews.llvm.org/D102361
___
jhuber6 updated this revision to Diff 354324.
jhuber6 added a comment.
Addings tests and a module flag for openmp target devices.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102361/new/
https://reviews.llvm.org/D102361
Files:
clang/lib/CodeGen
jdoerfert added a comment.
tests missing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102361/new/
https://reviews.llvm.org/D102361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
jhuber6 created this revision.
jhuber6 added a reviewer: jdoerfert.
Herald added subscribers: guansong, yaxunl.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
This patch adds a module level metadata flag indicating that th
