[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Andreas-Krebbel added a comment. > But looking at the GCC sources, it seems we actually intended to support this > use as well, there's just a bug. Given that, I think I'd be fine with > adding this to LLVM -- I'll make sure the GCC bug gets fixed as well. I've fixed the GCC issue now: https

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa168fc50ba: Parse vector bool when stdbool.h and altivec.h are included (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. Expected Z behavior LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with comment. Comment at: clang/test/Parser/altivec-zvector-bool.c:20-23 +__vector _Bool char Bc; +__vector _Bool short Bsh; +__vector _B

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 344785. ZarkoCA added a comment. - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. xlc on z/OS will compile vector _Bool char bc; on any language level high enough to recognize _Bool as a valid keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 _

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751160 , @uweigand wrote: > In D102064#2751089 , @ZarkoCA wrote: > >> In D102064#2751001 , @uweigand >> wrote: >> >>> This means the

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. In D102064#2751089 , @ZarkoCA wrote: > In D102064#2751001 , @uweigand > wrote: > >> This means the implementation now deviates from the documented vector >> extension syntax, right? I

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2750930 , @Everybody0523 wrote: > Minor nitpick, but is there a term that encompasses both the Z Vector syntax > and altivec? Since the test checks both Z and PPC it's a little odd that the > test's filename only ref

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751001 , @uweigand wrote: > This means the implementation now deviates from the documented vector > extension syntax, right? I guess it's strictly an extension of the > documented syntax, but that may still lead to

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. This means the implementation now deviates from the documented vector extension syntax, right? I guess it's strictly an extension of the documented syntax, but that may still lead to incompatibilities with other compilers for the platform. If we want to make such a

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. Minor nitpick, but is there a term that encompasses both the Z Vector syntax and altivec? Since the test checks both Z and PPC it's a little odd that the test's filename only references altivec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 344426. ZarkoCA edited the summary of this revision. ZarkoCA added reviewers: uweigand, neumannh. ZarkoCA added a comment. - clean up code per comments - Add test case for Z targets since that target is also affected Repository: rG LLVM Github Monorepo CH

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7331-7332 } -if (Next.getIdentifierInfo() == Ident_bool) { +if ((Next.getIdentifierInfo() == Ident_bool) || +Next.getIdentifierInfo() == Ident_Bool) { Tok.setKind(t

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

nemanjai added a comment. This seems fine to me now but I'll defer to front end experts for approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 ___ cfe-co

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; nemanjai wrote: > Do we not want the test case to provide a similar define to what `stdbool.h`

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 343656. ZarkoCA added a comment. - update test cases to contain `_Bool` as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files: clang/include/clang/Parse/Par

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

nemanjai added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; Do we not want the test case to provide a similar define to what `stdbool.h` does? Repositor

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA created this revision. ZarkoCA added reviewers: PowerPC, clang, cebowleratibm, hubert.reinterpretcast, bmahjour. ZarkoCA added projects: clang, PowerPC. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Currently when including stdbool.h and altivec.h decl