[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-05 Thread Thomas Lively via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG602f318cfdac: [WebAssembly] Fix constness of pointer params to load intrinsics (authored by tlively). Changed prior to commit: https://reviews.llv

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-05 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. In D101884#2739898 , @aheejin wrote: > I see, thanks. Then other load instructions are OK not to be fixed? > > - `v128.load` > - `v128.loadN_splat` > - `v128.loadNxM_s/u` Yep, the intrinsics for those instructions were already us

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-05 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I see, thanks. Then other load instructions are OK not to be fixed? - `v128.load` - `v128.loadN_splat` - `v128.loadNxM_s/u` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-05 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. It only matters for pointer parameters. For example, `const int *` is meaningfully different from `int *`, but `const int` is not usefully different from `int`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ ht

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-05 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Why do only these instructions have `const`? It doesn't apply to other read-only arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ https://reviews.llvm.org/D101884 __

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

2021-05-04 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the SIMD builtin load