This revision was automatically updated to reflect the committed changes.
Closed by commit rG7907c46fe619: Make clangd CompletionModel not depend on
directory layout. (authored by hvdijk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101851/new/
ht
usaxena95 accepted this revision.
usaxena95 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:9
function(gen_decision_forest model filename cpp_class)
- set(model_compiler
${LLVM_EXTERNAL_
hvdijk marked an inline comment as done.
hvdijk added inline comments.
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7
# namespace-qualified class name.
+set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR})
function(gen_decision_forest model filename cpp_class
hvdijk updated this revision to Diff 342881.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101851/new/
https://reviews.llvm.org/D101851
Files:
clang-tools-extra/clangd/quality/CompletionModel.cmake
Index: clang-tools-extra/clangd/quality/Complet
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7
# namespace-qualified class name.
+set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR})
function(gen_decision_forest model filename cpp_class)
nit: Directly refer
hvdijk created this revision.
hvdijk added reviewers: sammccall, usaxena95.
hvdijk added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgorny.
hvdijk requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
The current code acc
