[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2740150 , @tlively wrote: > @dblaikie, what's the best practice for making tests robust to this > difference? If you need a label or register (eg: if you want to check a branch branches to some particular spot) - th

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. @dblaikie, what's the best practice for making tests robust to this difference? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101805/new/ https://reviews.llvm.org/D101805 ___ cfe

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2739814 , @tlively wrote: > Thanks, @hans! That's very surprising; I'll take a deeper look at what was > going wrong. Labels (& instructions/values) are only named in ASSERTS enabled builds (or you can opt into them

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. Thanks, @hans! That's very surprising; I'll take a deeper look at what was going wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101805/new/ https://reviews.llvm.org/D101805 __

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

hans added a comment. The test was failing in no-asserts builds, see output at https://ghostbin.com/paste/UMtJl I put "REQUIRES: asserts" on it in 4f4aa7b78df5544b0a1c07ee98475939c1175990 for now. Repository: rG LLVM Gith

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2737531 , @tlively wrote: > At just under 4 seconds on my machine, it's certainly not one of the quickest > clang lit tests, but neither is it one of the slowest. It looks like there > are many that take tens of seco

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. At just under 4 seconds on my machine, it's certainly not one of the quickest clang lit tests, but neither is it one of the slowest. It looks like there are many that take tens of seconds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. how's the runtime of this test compared to others in clang? Is it worth splitting it up to improve test execution parallelism? (I'm guessing /probably not/ (guess while the file is long, it's relatively simple for the compiler compared to some other non-trivial templat