[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG159dd447fe98: [clangd][ObjC] Highlight Objc Ivar refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman added a comment. In D101785#2741535 , @kadircet wrote: > Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as > that's where the underlying change lies. > > To disambiguate properties and ivars, what if we used modifiers? I s

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343409. dgoldman added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

kadircet added a comment. Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as that's where the underlying change lies. To disambiguate properties and ivars, what if we used modifiers? I suppose we can mark properties with `abstract` modifier, but i am not an obj-c person so

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343087. dgoldman added a comment. Another attempt... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 342734. dgoldman added a comment. Fix test broken on non-macOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Treat them just l