[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-05-03 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hans marked 2 inline comments as done. Closed by commit rG876bf516e7d4: [clang-cl] Add parsing support for a bunch of new flags (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-05-03 Thread Hans Wennborg via Phabricator via cfe-commits
hans marked 2 inline comments as done. hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:6117 def _SLASH_favor : CLJoined<"favor">; +def _SLASH_fsanitize_address_use_after_return : CLJoined<"fsanitize-address-use-after-return">; +def _SLASH_fno_sanit

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Great :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101439/new/ https://reviews.llvm.org/D101439 ___

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-04-28 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D101439#2722540 , @thakis wrote: > Do we silently ignore those all now? Are any of them semantically important > enough that we should emit an "not implemented, ignoring" diag instead? No, this patch makes us parse them as oppos

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/include/clang/Driver/Options.td:6117 def _SLASH_favor : CLJoined<"favor">; +def _SLASH_fsanitize_address_use_after_return : CLJoined<"fsanitize-address-use-after-return">; +def _SLASH_fno_sanitize_address_vcasan_lib : CLJoined<"f

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Do we silently ignore those all now? Are any of them semantically important enough that we should emit an "not implemented, ignoring" diag instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101439/new/ https://reviews.l

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

2021-04-28 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added reviewers: thakis, rnk. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. MSVC has added some new flags. Although they're not supported, this adds parsing support for them so clang-cl doesn't treat them a