[PATCH] D101400: [Driver] Add -print-multiarch-triple

2022-09-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Herald added subscribers: abrachet, StephenFan. Herald added a project: All. In D101400#2990254 , @jrtc27 wrote: > Answering the last part myself: GCC only has MULTIARCH_DIRNAME definitions > for various linux-gnu*, linux-musl, l

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-09-08 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Answering the last part myself: GCC only has MULTIARCH_DIRNAME definitions for various linux-gnu*, linux-musl, linux-uclibc, kfreebsd-gnu and -gnu (as an OS, for GNU/Hurd) targets, everything else prints a blank string here. So either we need to decide what the right beh

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-09-08 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. This includes the version number, at least for FreeBSD, in its output, which doesn't make a huge deal of sense to me. This then breaks the build of Python because it generates a module with a name like `_sysconfigdata__freebsd14_x86_64-unknown-freebsd14.0.py`, and when i

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Petr Hosek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa921d2d2fb46: [Driver] Add -print-multiarch (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 341015. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Dri

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG Comment at: clang/test/Driver/print-multiarch.c:5 +// RUN:-resource-dir=%S/Inputs/resource_dir \ +// RUN: | FileCheck --check-prefix=PRINT-MULTIARCH %s +//

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D101400#2720954 , @MaskRay wrote: > gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our > semantics are compatible. I wasn't aware that GCC already has this option but using the same spelling definitely mak

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 341001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our semantics are compatible. It seems odd to have print-runtime-dir tests in `immediate-options.c`. The tests should be moved to a `print-*` file. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101400: [Driver] Add -print-multiarch-triple

2021-04-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: rnk, MaskRay. Herald added a subscriber: dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful in runtimes build for example which currently try to guess the correc