[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

2021-04-28 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cb2305a1e8: [clangd] Add SymbolID to LocatedSymbol. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

2021-04-28 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 341168. usaxena95 marked 4 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101388/new/ http

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

2021-04-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, but can you amend the description a bit? > We do not have to both locate the symbol and also query the SymbolID (using > getSymbolInfo). IIRC this isn't really the reason, it's beca

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

2021-04-27 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is useful for running cl