[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul added a comment. I try to make Hurd.cpp close to Linux.cpp in general, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing lis

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe37c8fd364a9: Hurd: Clean up Debian multiarch /usr/include/ (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I see that this makes the code similar to the similar logic in Linux.cpp. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul added a comment. No, for now it only supports i686. This part is actually already being tested by hurd.cpp, /usr/include/i386-gnu wouldn't be getting included otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://re

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Does Hurd support non-i386? Ideally this should have a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing li

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul added a comment. FI, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 __

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

2021-04-26 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up of 35dd6470de84 for the Hurd case, to avoid the duplication