This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdaca6edb31ef: Thread safety analysis: Fix false negative on
break (authored by aaronpuchert).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for explaining the test cases, that helped (and I agree that
the drive-by test changes look sensible to me).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
aaronpuchert added inline comments.
Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:341
+ sls_mu.Unlock(); // \
+// expected-warning{{releasing mutex 'sls_mu' that was not held}}
}
This is just a side effect, not the reason I did the change.
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We weren't modifying the lock set when intersecting with one coming
from a break-termina
