[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ aheejin wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f54049d17: [WebAssembly] Finalize wasm_simd128.h intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:969 +static __inline__ v128_t __DEFAULT_FN_ATTRS wasm_f32x4_ceil(v128_t __a) { + return (v128_t)__builtin_wasm_ceil_f32x4((__f32x4)__a); +} aheejin wrote: > Sometimes builtin names seem

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ dschuff wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added a comment. In D101112#2710521 , @aheejin wrote: > General question about SIMD intrinsics: So we make dedicated wasm intrinsics > only for the cases there are not general intrinsics people can use instead? No, every instruction in the propo

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively updated this revision to Diff 340109. tlively added a comment. - "stand" => "standard" - Update builtins for v128.any_true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101112/new/ https://reviews.llvm.org/D101112 Files: clang/include/cl

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

dschuff added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ aheejin wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added a comment. General question about SIMD intrinsics: So we make dedicated wasm intrinsics only for the cases there are not general intrinsics people can use instead? Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i)

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

penzn accepted this revision. penzn added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101112/new/ https://reviews.llvm.org/D101112

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

dschuff added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ out of curiosit

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds new intrinsics for instruc