[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81dae18dff7f: [clangd] Allow AST request without range (authored by ckandeler, committed by sammccall). Changed prior to commit: https://reviews.l

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D101057#2711997 , @sammccall wrote: > Want me to land this for you? Yes, please. I don't have push privileges. Thanks for the prompt and helpful review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 340014. ckandeler added a comment. Fixed remaining issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thank you! Just a couple of nits. Want me to land this for you? Comment at: clang-tools-extra/clangd/DumpAST.cpp:339 + + bool TraverseTUDecl(TranslationUni

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339995. ckandeler marked 2 inline comments as done. ckandeler added a comment. "top-level" -> "root" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339994. ckandeler added a comment. Fixed TU traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:895 + auto Node = DynTypedNode::create( +*Inputs->AST.getASTContext().getTranslationUnitDecl()); + return CB(dumpAST(Node, Inputs->AST.getTokens(), ---

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339948. ckandeler added a comment. Herald added a subscriber: cfe-commits. Addressed clang-tidy and clang-format comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D10