This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0f7d4105c60b: [clang][deps] Only generate absolute paths
when asked to (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SI
jansvoboda11 updated this revision to Diff 340449.
jansvoboda11 retitled this revision from "[clang][deps] Only generate
modules-related paths when asked to" to "[clang][deps] Only generate absolute
paths when asked to".
jansvoboda11 edited the summary of this revision.
jansvoboda11 added a comme
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit to pick.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:392
std::vector ModuleDeps;
-std::vector AdditonalCommandLine;
+std
jansvoboda11 updated this revision to Diff 339944.
jansvoboda11 added a comment.
Improve naming
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101051/new/
https://reviews.llvm.org/D101051
Files:
clang/include/clang/Tooling/DependencyScanning/Depe
jansvoboda11 created this revision.
jansvoboda11 added a reviewer: Bigcheese.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add option to `clang-scan-deps` to enable/disable generation of command-line
arguments with absolute