This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
dexonsmith marked an inline comment as done.
Closed by commit rGd4ee603c8f21: Coverage: Document how to collect a profile
without a filesystem (authored by dexonsmith).
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
This looks great, thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101000/new/
https://reviews.llvm.org/D101000
___
cfe-commits mailing lis
dexonsmith marked an inline comment as done.
dexonsmith added inline comments.
Comment at: clang/docs/SourceBasedCodeCoverage.rst:368
+
+In C++ files, declare these as ``extern "C"``.
+
vsk wrote:
> I think we should leave a note about how to avoid pulling in unw
dexonsmith updated this revision to Diff 339423.
dexonsmith added a comment.
Incorporate feedback from @vsk:
- a bit more explanatory text for the overall context
- explicitly reference the static initializers
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101000/new/
https://reviews.ll
vsk added a subscriber: efriedma.
vsk added a comment.
Thanks for doing this!
+ Eli to comment on whether any workarounds documented in
https://lists.llvm.org/pipermail/llvm-dev/2017-September/117156.html are still
necessary. To my knowledge it's not currently necessary to explicitly pass
-mll
dexonsmith created this revision.
dexonsmith added a reviewer: vsk.
dexonsmith requested review of this revision.
Herald added a project: clang.
The profiling runtime was designed to work without static initializers
or a a filesystem (see 117cf2bd1ff585f9754b5f30f5a4cfd65b230bbf and
others). The n
