[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D100981#2709450 , @thakis wrote: > maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken > atm Fixed by vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken atm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100981/new/ https://reviews.llvm.org/D100981 ___ cfe

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. Would it make sense for you to to upstream an LLVM target such as le32-halide? (Or perhaps even arm32-halide or some other?) Then you'd actually have more control over your own codegen, datalayout, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Steven Johnson via Phabricator via cfe-commits
srj added a comment. In D100981#2709205 , @MaskRay wrote: > In D100981#2709044 , @srj wrote: > >> Any chance that this could be (temporarily) reverted? This will break >> literally all Halide compilation; we're w

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Herald added a subscriber: tmatheson. In D100981#2709044 , @srj wrote: > Any chance that this could be (temporarily) reverted? This will break > literally all Halide compilation; we're working on a fix on our side, but it > woul

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Steven Johnson via Phabricator via cfe-commits
srj added a comment. Any chance that this could be (temporarily) reverted? This will break literally all Halide compilation; we're working on a fix on our side, but it would be nice to have a few days to be sure we have it right, and I suspect there's no urgency to removing this right now. Re

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Andrew Adams via Phabricator via cfe-commits
abadams added a comment. In D100981#2706899 , @dschuff wrote: > Thanks. I had heard in the past that there were some other folks who had used > le32/le64 as a "generic" target (in fact that's why it's named so > generically, rather than being called "pn

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ac823fd285: Delete le32/le64 targets (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Derek Schuff via Phabricator via cfe-commits
dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. Thanks. I had heard in the past that there were some other folks who had used le32/le64 as a "generic" target (in fact that's why it's named so generically, rather than being called "pnacl"

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: dschuff. Herald added subscribers: dexonsmith, jfb, hiraditya, mgorny. MaskRay requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. They are unused now. Note: N