[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0ca4c46ca35: [Debug-Info] add -gstrict-dwarf support in backend (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100826?vs=339840&id=345022#toc Repository: rG LLVM Github Mo

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339840. shchenz added a comment. 1: put test cases in single file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D100826 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/in

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie accepted this revision. dblaikie added a comment. Sounds good - probably only need one test file, rather than two - can put a bunch of strict-dwarf related testing in that one file (& honestly, maybe don't even need to test every DWARF attribute gets the right handling if the handling

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339470. shchenz added a comment. Herald added a subscriber: nemanjai. 1: add NFC testcases to use `-gstrict-dwarf` option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D1008

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie added a comment. In D100826#2707145 , @shchenz wrote: > In D100826#2702135 , @dblaikie > wrote: > >> Do you know if you're going to be using LTO with DBX? If so, to respect this >> flag, it would need t

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz added a comment. In D100826#2702135 , @dblaikie wrote: > Do you know if you're going to be using LTO with DBX? If so, to respect this > flag, it would need to be added to LLVM IR module metadata (like the Dwarf > Version and Debug Info Version f

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie added a comment. Do you know if you're going to be using LTO with DBX? If so, to respect this flag, it would need to be added to LLVM IR module metadata (like the Dwarf Version and Debug Info Version fields) rather than as an MCOption. (we're pretty wishy-washy about what things we dec

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. You have a clang-format warning, aside from that LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added a subscriber: hiraditya. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l