[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG645c5f27a84d: [RISCV] Implement the pseudo compare builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100823?vs=339879&id=340444#toc Repository: rG LLVM Github Monor

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 ___

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339879. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339876. HsiangKai added a comment. Use new defined intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-21 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D100823#2704120 , @craig.topper wrote: > I just posted https://reviews.llvm.org/D100889 which should allow the > frontend to treat all comparisons the same way. It also avoids using the long > expansion for vmsge.vx I wil

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I just posted https://reviews.llvm.org/D100889 which should allow the frontend to treat all comparisons the same way. It also avoids using the long expansion for vmsge.vx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Thinking about this more, I'd like to consider doing this in the backend specifically for the compares for a few reasons. -vmsgt(u).vv intrinsic already selects vmslt(u).vv with swapped operands in the backend. This was needed for SEW=64 on RV32. -Inconsistent that

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-20 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, khchen, frasercrmck. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jon