[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c3e23ba09: [AST] Fix comparison to of SourceRanges in container (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100723/new/ htt

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const &RHS) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false;

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const &RHS) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false; njames93 wrote: > Maybe we should assert the ranges (or locations) ar

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const &RHS) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false; Maybe we should assert the ranges (or locations) are valid before ins

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100723 Files: clang/lib/Tooling/NodeIntrospect