[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

2021-04-25 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG753b247d71d7: [clangd] Omit parameter hint if parameter name comment is present (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

2021-04-25 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 340391. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100715/new/ https://reviews.llvm.org/D100715 Files: clang-tools-e

[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

2021-04-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Just a few optional ideas, this is fine as-is Comment at: clang-tools-extra/clangd/InlayHints.cpp:108 +// Allow the comment