This revision was automatically updated to reflect the committed changes.
Closed by commit rG21ce124e1e63: [AST] Add NestedNameSpecifierLoc accessors to
node introspection (authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1007
steveire updated this revision to Diff 338631.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100712/new/
https://reviews.llvm.org/D100712
Files:
clang/lib/Tooling/DumpTool/APIData.h
clang/lib/Tooling/DumpTool/A
steveire added inline comments.
Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280
STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc())
}));
// clang-format on
steveire wrote:
> njames93 wrote:
> > I'm not entirely sure on the case,
steveire updated this revision to Diff 338620.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100712/new/
https://reviews.llvm.org/D100712
Files:
clang/lib/Tooling/DumpTool/APIData.h
clang/lib/Tooling/DumpTool/A
steveire added inline comments.
Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280
STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc())
}));
// clang-format on
njames93 wrote:
> I'm not entirely sure on the case, but the windows bot
njames93 added inline comments.
Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280
STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc())
}));
// clang-format on
I'm not entirely sure on the case, but the windows bot is giving a [[
ht
steveire added inline comments.
Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:57
InstanceDecoration = "*"
-if CladeName == "TypeLoc":
+if CladeName == "TypeLoc" or CladeName == "NestedNameSpecifierLoc":
InstanceDecoration =
njames93 added inline comments.
Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:57
InstanceDecoration = "*"
-if CladeName == "TypeLoc":
+if CladeName == "TypeLoc" or CladeName == "NestedNameSpecifierLoc":
InstanceDecoration =
steveire created this revision.
steveire added a reviewer: njames93.
Herald added subscribers: mgrang, mgorny.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Change the GetLocations API to take instances by const-ref. This class
