This revision was automatically updated to reflect the committed changes.
njames93 marked an inline comment as done.
Closed by commit rGb23abbeab1d7: [AST] Use IntrusiveRefCntPtr for Introspection
LocationCall. (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
steveire added a comment.
Indeed, I just this evening discovered the need for this to be stable across
runs for testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100378/new/
https://reviews.llvm.org/D100378
__
dblaikie added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
njames93 wrote:
> dblaikie wrote:
> > njames93 wrote:
> > >
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
dblaikie wrote:
dblaikie added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
njames93 wrote:
> dblaikie wrote:
> > njames93 wrote:
> > >
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
dblaikie wrote:
dblaikie added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
njames93 wrote:
> This is a slight change in behaviour, The
njames93 added inline comments.
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+ if (LHS.first == RHS.first)
+return LHS.second->name() < RHS.second->name();
+ return LHS.first < RHS.first;
This is a slight change in behaviour, The old implementatio
njames93 created this revision.
njames93 added a reviewer: steveire.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D100378
Files:
clang/include/clang/Tooling/Node
