[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

2021-04-13 Thread Artur Gainullin via Phabricator via cfe-commits
ArturGainullin added a comment. In D100361#2686823 , @rnk wrote: > Example: > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Driver/ToolChainTest.cpp#L29 Thank you for the example! I will take a look and may consider adding a test as a

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

2021-04-13 Thread Artur Gainullin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG192c6023e1e2: [Driver] Make the findVCToolChainViaEnvironment case-insensitive (authored by ArturGainullin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

2021-04-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Example: https://github.com/llvm/llvm-project/blob/main/clang/unittests/Driver/ToolChainTest.cpp#L29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100361/new/ https://reviews.llvm.org/D100361 _

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

2021-04-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm This code could greatly benefit from some unit tests similar in style to the GCC installation detection tests, but It would be unreasonable for me to insist on them. Repository: rG LLVM Gi

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

2021-04-12 Thread Artur Gainullin via Phabricator via cfe-commits
ArturGainullin created this revision. ArturGainullin added reviewers: rnk, hamzasood. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PATH usage on Windows is case-insensitive. There could be situations when toolchain path ca