[PATCH] D100347: Fix the const overload of IgnoreExprNodes

gribozavr2 added a comment. > Trying arc land I realize I do not... Pushed as 595c3758e47042c876e7390d09642ea050ba6dbf . > it's also unclear to me where the tests for this are so I couldn't add a new > test, is that OK? Yes,

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

This revision was automatically updated to reflect the committed changes. Closed by commit rG595c3758e470: Fix the const overload of IgnoreExprNodes (authored by d, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ h

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. More importantly, the bug exists in LLVM 12, what is the policy of patching the back branches in this project? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 _

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. @gribozavr2 it's also unclear to me where the tests for this are so I couldn't add a new test, is that OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 _

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. In D100347#2684934 , @gribozavr2 wrote: > Thanks for the fix! Do you have commit access? Trying `arc land` I realize I do not... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D10034

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d updated this revision to Diff 336983. d added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 Files: clang/include/clang/AST/IgnoreExpr.h Index: clang/include/clang/AST/IgnoreExpr.

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d created this revision. d requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The existing code causes an infinite recursion. This is likely an oversight of commit c0e5e3fbfa504c37