This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e9ac4138890: [clangd] Drop optional on ExternalIndexSpec
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet updated this revision to Diff 349379.
kadircet added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100308/new/
https://reviews.llvm.org/D100308
Files:
clang-tools-extra/clangd/Config.h
clang-tools-extra/clangd/Config
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555
+ case Config::ExternalIndexSpec::None:
+break;
case Config::ExternalIndexSpec::Server:
sammccall wrote:
> I think you hit llvm_unreachable here - is this an inva
kadircet updated this revision to Diff 349378.
kadircet marked an inline comment as done.
kadircet added a comment.
Add comment to IndexFactory about pre-condition of spec never being none.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100308/new/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: cfe-commits.
Sorry about delay.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555
+ case Config::ExternalIndexSpec::None:
+br
