This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8f0a7c215ab: [NewPM] Cleanup IR printing instrumentation
(authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jamieschmeiser accepted this revision.
jamieschmeiser added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100231/new/
https://reviews.llvm.org/D100231
___
aeubanks added a comment.
I'm not sure that having a helper method with 4 lambdas is any cleaner. Normal
control flow in a function is easier to read and understand, and not really
that much more code.
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:222
if (any_
aeubanks updated this revision to Diff 337572.
aeubanks marked 2 inline comments as done.
aeubanks added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
