Re: [PATCH][Modules][PR26179]

Thanks! --Vassil On 22/01/16 20:07, Yaron Keren wrote: Committed revision 258524. 2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits mailto:cfe-commits@lists.llvm.org>>: ping... (perhaps someone else with commit rights can check it it...) --Vassil On 18/01/16 22:07, Vass

Re: [PATCH][Modules][PR26179]

Committed revision 258524. 2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org>: > ping... (perhaps someone else with commit rights can check it it...) > --Vassil > > On 18/01/16 22:07, Vassil Vassilev wrote: > > Thanks! Could you check it in? > -- Vassil > On

Re: [PATCH][Modules][PR26179]

ping... (perhaps someone else with commit rights can check it it...) --Vassil On 18/01/16 22:07, Vassil Vassilev wrote: Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" > w

Re: [PATCH][Modules][PR26179]

Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" > wrote: Attaching v3 of the patch. Added your case to the current test and fixed my silly non-array mistake.

Re: [PATCH][Modules][PR26179]

LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" wrote: > Attaching v3 of the patch. Added your case to the current test and fixed > my silly non-array mistake. > -- Vassil > On 18/01/16 20:38, Richard Smith wrote: > > Please also add a test case that your old patch would have failed on, such > a

Re: [PATCH][Modules][PR26179]

Attaching v3 of the patch. Added your case to the current test and fixed my silly non-array mistake. -- Vassil On 18/01/16 20:38, Richard Smith wrote: Please also add a test case that your old patch would have failed on, such as: m1.h: extern int a[]; m2.h: extern int a[5]; x.cc: #include

Fwd: Re: [PATCH][Modules][PR26179]

ith" Date: Jan 18, 2016 11:38 AM Subject: Re: [PATCH][Modules][PR26179] To: "Vassil Vassilev" Cc: "Douglas Gregor" , "cfe commits" < cfe-comm...@cs.uiuc.edu> > Please also add a test case that your old patch would have failed on, such as: > &

[PATCH][Modules][PR26179]

Hi, Could somebody review the attached patch. It fixes https://llvm.org/bugs/show_bug.cgi?id=26179 Many thanks! Vassil From 947a163ab4e13c44625085dd51faa656b72de3ac Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 16 Jan 2016 23:52:40 +0100 Subject: [PATCH] [modules] Teach clang to