strager added inline comments.
Comment at: include/experimental/memory_resource:433
+char *__cur_;
+size_t __align_;
+size_t __allocation_size() {
> Eric suggests replacing size_t __align_ with uint8_t __log2_align_. I'm
> amenable to thi
strager added inline comments.
Comment at: include/experimental/memory_resource:427
+static _LIBCPP_CONSTEXPR const size_t __default_buffer_capacity = 1024;
+static _LIBCPP_CONSTEXPR const size_t __default_buffer_alignment = 16;
+
Nit: Why isn't `__defaul
strager added a comment.
Ping! I'd like a code review for this bug fix.
Repository:
rC Clang
https://reviews.llvm.org/D45713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
strager created this revision.
strager added a reviewer: cfe-commits.
Herald added subscribers: chrib, kristof.beyls, javed.absar.
Both sides of this #if #include the same file. Drop the #if, leaving only the
#include.
This commit should not change behaviour.
Repository:
rC Clang
https://re
strager created this revision.
strager added a reviewer: cfe-commits.
libclang exposes the type of 'int (Foo);' (a global variable of type int
called Foo) as CXType_Unexposed. This is because Clang represents Foo's
type as ParenType{BuiltinType{Int}}, and libclang does not handle
ParenType.
Make
strager created this revision.
Herald added a subscriber: klimek.
clang-format completely ruins the formatting of block literal
expressions which appear inside inside braced initializer lists. For
example:
int main() {
foo({
^() {
return nil;
}
});