[PATCH] D47111: : Implement monotonic_buffer_resource.

2019-10-11 Thread strager via Phabricator via cfe-commits
strager added inline comments. Comment at: include/experimental/memory_resource:433 +char *__cur_; +size_t __align_; +size_t __allocation_size() { > Eric suggests replacing size_t __align_ with uint8_t __log2_align_. I'm > amenable to thi

[PATCH] D47111: : Implement monotonic_buffer_resource.

2019-10-11 Thread strager via Phabricator via cfe-commits
strager added inline comments. Comment at: include/experimental/memory_resource:427 +static _LIBCPP_CONSTEXPR const size_t __default_buffer_capacity = 1024; +static _LIBCPP_CONSTEXPR const size_t __default_buffer_alignment = 16; + Nit: Why isn't `__defaul

[PATCH] D45713: [libclang] Fix the type of 'int (Foo);'

2018-04-26 Thread strager via Phabricator via cfe-commits
strager added a comment. Ping! I'd like a code review for this bug fix. Repository: rC Clang https://reviews.llvm.org/D45713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45779: [ARM] Remove redundant #if in test

2018-04-18 Thread strager via Phabricator via cfe-commits
strager created this revision. strager added a reviewer: cfe-commits. Herald added subscribers: chrib, kristof.beyls, javed.absar. Both sides of this #if #include the same file. Drop the #if, leaving only the #include. This commit should not change behaviour. Repository: rC Clang https://re

[PATCH] D45713: [libclang] Fix the type of 'int (Foo);'

2018-04-16 Thread strager via Phabricator via cfe-commits
strager created this revision. strager added a reviewer: cfe-commits. libclang exposes the type of 'int (Foo);' (a global variable of type int called Foo) as CXType_Unexposed. This is because Clang represents Foo's type as ParenType{BuiltinType{Int}}, and libclang does not handle ParenType. Make

[PATCH] D40221: [clang-format] Parse blocks in braced lists

2017-11-18 Thread strager via Phabricator via cfe-commits
strager created this revision. Herald added a subscriber: klimek. clang-format completely ruins the formatting of block literal expressions which appear inside inside braced initializer lists. For example: int main() { foo({ ^() { return nil; } });