[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 added a comment. In D153370#4447824 , @craig.topper wrote: > In D153370#4447817 , @garvitgupta08 > wrote: > >> Addressed the changes. I do not have commit access, could you please commit >> this d

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 534437. garvitgupta08 added a comment. Addressed the changes. I do not have commit access, could you please commit this differential on my behalf? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 534018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153370/new/ https://reviews.llvm.org/D153370 Files: clang/test/Driver/riscv-cpus.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 533668. garvitgupta08 added a comment. Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153370/new/ https://reviews.llvm.org/D153370 Files: llvm/docs/RISCVUsage.rst llvm/docs/Rele

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 created this revision. garvitgupta08 added reviewers: asb, apazos, jrtc27. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, z

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:980-981 +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputType = types::lookupTypeForExtension( +llvm::sys::path::extension(BaseInput).drop_front()); +if (I

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4228406 , @MaskRay wrote: > Please update the commit message and comment about what binutils versions > reject the construct. I already added this - "Due to this we started seeing below assembler error with GNU

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4228216 , @nickdesaulniers wrote: > @garvitgupta08 what's your email address so that I may attribute your > authorship correctly when committing on your behalf? quic_garvg...@quicinc.com. Thanks for committing!

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. I do not have the commit access, can you commit on my behalf @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputTyp

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputTyp

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 updated this revision to Diff 508328. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/as-options.cpp clang/test/Driver/gcc_forward.c Index: clang/test/Driver/gcc_

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4194142 , @nickdesaulniers wrote: > The description needs to be rewritten to elucidate that this is purely to > support old versions of the GNU assembler still in use by various Linux LTS > distros. This probl

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 updated this revision to Diff 507144. garvitgupta08 marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/t

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 updated this revision to Diff 505171. garvitgupta08 added a comment. Addressed the comments. Using gcc_forward.c for checking c extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Fil

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4190316 , @nickdesaulniers wrote: > Isn't this only an issue with ancient versions of GNU as? Older than 2.16? I am able to reproduce this issue with 4.9.0 GNU as. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. Added the testcase in the commit message itself. Thanks Eli for providing the same! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 ___

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 created this revision. garvitgupta08 added reviewers: apazos, efriedma, MaskRay, nickdesaulniers. Herald added a project: All. garvitgupta08 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D136309