[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh added a comment. > My expectation was that @fiesh would be updating the review if they wanted > this to land. If they indicate they're no longer interested in working on the > patch, then I think it's fine for you to commandeer the patch. But you should > give them a chance to speak up in

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh added a comment. @aaron.ballman valid point. It would seem natural to diagnose both since the user is voluntarily causing the decay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 _

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh marked 6 inline comments as done. fiesh added a comment. @njames93 Thank you for your review, I hopefully addressed all your points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh updated this revision to Diff 296452. fiesh added a comment. Applied changes to address code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 Files: clang-tools-extra/clang-tidy/cppcoreguidel

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Continued in https://reviews.llvm.org/D88833 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D88833: Do not warn on pointer decays in system macros

fiesh created this revision. fiesh added a reviewer: aaron.ballman. fiesh added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. fiesh requested review of this revision. As system headers are in general out of reach, it makes no

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Ping everybody? This is a rather important issue I think since it makes clang-tidy not usable in a lot of cases, and the fix would be all done. Please let's get this merged! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D311

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. @JonasToth could you please clarify if the original author's comment is sufficient grants of rights? If so, from what I can tell if the commit message was adapted to reflect that this removes false positives with system macros like `assert`, this would be good to go? C

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. > I guess we need specific permission from the author. maybe writing a mail to > him/her would work? Then he/she can give permission (or decline it, which is > unexpected i guess). I already wrote an email a couple weeks ago but haven't received a reply so far. Let's ho

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. In D31130#1711841 , @lebedev.ri wrote: > The description only says what the patch does, not why this is the desired > behavior. > Also, this is now under a wrong license. What are the options in case the original author has aband

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Herald added a subscriber: wuzish. Ping! Am I correct in that basically everything's done here and this has been lingering ever since? It would be great if the change could make it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.o