Thank you very much, Zachary :)
From: Zachary Turner [mailto:ztur...@google.com]
Sent: Monday, December 11, 2017 4:21 PM
To: Zhen Cao
Cc: Benoit Belley ;
reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org; r...@google.com;
cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D41081: Fix clang L
I think adding two lit substitutions is not a significant issue since dos2unix
and unix2dos are common Unix utilities. This solution also has the advantage of
testing both styles of line-endings with only one test case, which I think
actually reduces complexity and maintenance burden.
From: Zac