[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f986bffc51a: [clang] Remove CGBuilderTy::CreateElementBitCast (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

JOE1994 updated this revision to Diff 536554. JOE1994 added a comment. - Add back in refactorings that either drop existing calls to CreateElementBitCast, or merge to Address creation. - Update commit message to clarify that we're employing 3 different methods to remove existing calls to Create

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] jrtc27 wrote: > jrtc27 wrote: > > JOE1994 w

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 updated this revision to Diff 536552. JOE1994 added a comment. - Undo some refactorings to make the diff more consistent with commit message (following feedback from @jrtc27) - Remove method CreateElementBitCast (following feedback from @nikic) Repository: rG LLVM Github Monorepo CH

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] nikic wrote: > JOE1994 wrote: > > > This i

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3896 llvm::Type *OrigBaseElemTy = Addr.getElementType(); -Addr = Builder.CreateElementBitCast(Addr, Int8Ty); barannikov88 wrote: > jrtc27 wrote: > > This one isn't a direct substit

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer()));

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] Repository: rG LLVM Github Monorepo C

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: luke, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f32baf17db1: [clang] Replace uses of CreateElementBitCast (NFC) (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 536398. JOE1994 added a comment. Rebase Wait to check whether the libCXX CI passes after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154229/new/ https://reviews.llvm.org/D154229 Files: clang/lib/C

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } barannikov88 wrote: > Just something to think about. > C

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 created this revision. JOE1994 added a reviewer: barannikov88. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towards replacing uses of CreateElementBitCast, as it no longer doe

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG474ec694191a: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153314/new

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 534913. JOE1994 added a comment. Apply suggested change from nikic (sorry, I missed it out in the previous update) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153314/new/ https://reviews.llvm.org/D153314 Fil

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 534598. JOE1994 added a comment. - Rebase onto latest main - Apply feedback from reviews - Rename `AtomicInfo::emitCastToAtomicIntPointer` to `AtomicInfo::castToAtomicIntPointer` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:90 +StoragePtr = CGF.Builder.CreateAddrSpaceCast( +StoragePtr, llvm::PointerType::getUnqual(CGF.getLLVMContext()), "atomic_bitfield_base"); barannikov88 wro

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: StephenFan, kbarton, nemanjai. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towa

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532424. JOE1994 added a comment. - git clang-format (update clang/lib/CodGen/CGBlocks.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/CodeGen/

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532422. JOE1994 added a comment. - Apply suggested change (combining 2 lines) from barannikov88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/Cod

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532421. JOE1994 added a comment. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. - Rebase onto latest llvm-project main - Remove awkward empty line in `clang/lib/CodeGen/CGBlocks.cpp`, as suggested by barannikov88 Repository: rG LLVM Github Mo

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532404. JOE1994 added a comment. - Apply suggestions from @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/CodeGen/Address.h clang/lib/Code

[PATCH] D152551: [clang] Remove dead parameter of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 abandoned this revision. JOE1994 added a comment. By mistake, I created a new revision D153196 instead of updating this one. Please refer to the new revision instead. I apologize for the inconvenience. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `Address::withElementType()` as a replacement for `CGBuilderTy::CreateElementBitCast`. - Partial progress towards re

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. With the updated revision, I don't see new test failures from `ninja check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja check-llvm-unit` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +AddrA

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 532164. JOE1994 added a comment. - Fix nullptr bug (fixes Clang regression test :` Clang :: CodeGen/constructor-attribute.c` ) - Following feedback from @barannikov88 - Rebase onto latest main : a76376cdb034d817803cbdb2f3f451487807124d

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. I do not have commit access yet. Could one of the reviewers land this patch for me? Please use "Youngsuk Kim " to commit the change. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2045 if (IsIndirect) -LLTy = LLTy->getPointerTo(0); +LLTy = llvm::PointerType::get(getVMContext(), 0); FrameFields.push_back(LLTy); nikic wrote: > getLLVMContext? `getLLVMCo

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531889. JOE1994 added a comment. - Rebase onto latest llvm-project main : 2cd4dc59792578f833b838e3c9a376a4bcafc568 - Use `llvm::PointerType::getUnqual` whenever possible Repository: r

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine &Name = "") { +return Address(Addr.getPointer(), Ty, barannikov88 wrot

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531593. JOE1994 added a comment. - Apply suggestions from barannikov88 - Used `git clang-format` to tidy up code format Thank you for your feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ ht

[PATCH] D152551: [clang] Remove dead parameter of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the 'Name' parameter of `CreateElementBitcast()`, which is unused. Depends on D152321

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(), Addr.isKnownNonNull(

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529976. JOE1994 added a comment. - Update uses of `PointerType::get(Ty)` & `PointerType::getUnqual` to be in overloaded form of `PointerType::get` that takes LLVMContext& - Remove more unnecessary bitcasts which were previously overlooked. - Remove pointee

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(), Addr.isKnownNonNull(

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. Some tests that run with `-no-opaque-pointers` began failing after I updated the revision to get rid of bitcasts. The bitcasts are still needed if running Clang with `-no-opaque-pointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529317. JOE1994 added a comment. If `getPointerTo()` is used just to support an unnecessary bitcast, just get rid of the bitcast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 created this revision. JOE1994 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towards replacing in-tree uses of `

[PATCH] D132521: [AST] Reuse PrintingPolicy from ASTContext

JOE1994 updated this revision to Diff 455157. JOE1994 added a comment. Add missed out 'const' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132521/new/ https://reviews.llvm.org/D132521 Files: clang/lib/Frontend/ASTConsumers.cpp Index: clang/li

[PATCH] D132521: [AST] Reuse PrintingPolicy from ASTContext

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. No need to create a duplicate PrintingPolicy when we can reuse the PrintingPolicy from ASTContext. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D113944: [CodeGenAction][NFC] Remove empty comment

JOE1994 created this revision. JOE1994 requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113944 Files: clang/lib/CodeGen/CodeGenAction.cpp Index: clang/lib/CodeGen/CodeGenAction.cpp ==