[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

2023-08-03 Thread Yi Kong via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cacb2f6efe: Fix __cfi_check not aligned to 4k on relocatable files with no executable code (authored by kongyi). Herald added a project: clang. Her

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

2022-10-15 Thread Yi Kong via Phabricator via cfe-commits
kongyi added a comment. In D135097#3859917 , @jrtc27 wrote: > It also will fail if the configured default target triple is one where the > default program address space is non-zero, and maybe other things (do any > targets do pre-IR name mangling for C?

[PATCH] D121683: Emit a warning if -xc/-xc++ is after the last input file

2022-03-15 Thread Yi Kong via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1a4b9556db: [clang][driver] Emit a warning if -xc/-xc++ is after the last input file (authored by kongyi). Herald added a project: clang. Herald ad

[PATCH] D108686: [clang] Don't generate warn-stack-size when the warning is ignored

2021-08-25 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc4828aa6c6: [clang] Don't generate warn-stack-size when the warning is ignored (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[PATCH] D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

2021-08-19 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca6d5813d175: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will… (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[PATCH] D103537: [clang][driver] Add -fno-visibility-inlines-hidden option

2021-06-03 Thread Yi Kong via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcd7664f92d3: Add -fno-visibility-inlines-hidden option (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D80541: Terminate early for DS_Error

2020-05-26 Thread Yi Kong via Phabricator via cfe-commits
kongyi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise clang will continue running after printing the diagnostic, causing failures later in other modes, or maybe even finish successfully. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320753: [ThreadSafetyAnalysis] Fix isCapabilityExpr (authored by kongyi, committed by ). Repository: rC Clang https://reviews.llvm.org/D41224 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabi

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
kongyi added a comment. In https://reviews.llvm.org/D41224#955213, @lebedev.ri wrote: > Hi. > I don't want to hijack the thread, but is PR32954 > likely unrelated to this fix, > and the problem (if it is a bug) is likely elsewhere? Should be unre

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
kongyi created this revision. kongyi added a reviewer: delesley. kongyi added a project: clang. Herald added a subscriber: cfe-commits. There are many more expr types that can be a capability expr, like CXXThisExpr, CallExpr, MemberExpr. Instead of enumerating all of them, just check typeHasCapabi

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

2017-09-25 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314124: [Sema] Null check in BuildDeclarationNameExpr (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D38158?vs=116279&id=116571#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

2017-09-25 Thread Yi Kong via Phabricator via cfe-commits
kongyi added a comment. ping... Repository: rL LLVM https://reviews.llvm.org/D38158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

2017-09-21 Thread Yi Kong via Phabricator via cfe-commits
kongyi created this revision. kongyi added a project: clang. Qualtype may point to null if we cannot infer its type yet. Fixes PR33843 Repository: rL LLVM https://reviews.llvm.org/D38158 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/typo-correction-crash.cpp Index: test/SemaCXX/typo-corre

[PATCH] D37995: [Docs] Document cache pruning support for gold

2017-09-18 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313591: [Docs] Document cache pruning support for gold (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D37995?vs=115710&id=115745#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D37995: [Docs] Document cache pruning support for gold

2017-09-18 Thread Yi Kong via Phabricator via cfe-commits
kongyi created this revision. kongyi added a project: clang. Herald added subscribers: eraman, mehdi_amini. Feature implemented in https://reviews.llvm.org/D37993 Repository: rL LLVM https://reviews.llvm.org/D37995 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst =

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

2017-06-13 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305315: Fix spurious Wunused-lambda-capture warning (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D33526?vs=102099&id=102371#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

2017-06-13 Thread Yi Kong via Phabricator via cfe-commits
kongyi added a comment. For normal captures, variables are safe to eliminate if they are non-ODR used or totally unused. However for init captures, non-ODR usage still depends on the capture; they are only safe to eliminate if totally unused. Repository: rL LLVM https://reviews.llvm.org/D33

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

2017-06-09 Thread Yi Kong via Phabricator via cfe-commits
kongyi updated this revision to Diff 102099. Repository: rL LLVM https://reviews.llvm.org/D33526 Files: lib/Sema/SemaLambda.cpp test/SemaCXX/warn-unused-lambda-capture.cpp Index: test/SemaCXX/warn-unused-lambda-capture.cpp =

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

2017-05-26 Thread Yi Kong via Phabricator via cfe-commits
kongyi added inline comments. Comment at: lib/Sema/SemaLambda.cpp:1524-1526 + if (!CurContext->isDependentContext() && !IsImplicit) +if ((IsGenericLambda && !From.isNonODRUsed()) || +(!IsGenericLambda && !From.isODRUsed())) malcolm.parson