[PATCH] D157331: [clang] Implement C23

2023-08-07 Thread Yabin Cui via Phabricator via cfe-commits
yabinc added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > > > > > is this

[PATCH] D157331: [clang] Implement C23

2023-08-07 Thread Yabin Cui via Phabricator via cfe-commits
yabinc accepted this revision. yabinc added a comment. This revision is now accepted and ready to land. LGTM, but please wait for a couple of days in case others wish to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://revie

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

2022-10-13 Thread Yabin Cui via Phabricator via cfe-commits
yabinc added a comment. Thanks @aaron.ballman. I don’t have commit access, can you land this patch for me? Please use “Yabin Cui yab...@google.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135896/new/ https://reviews.llv

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

2022-10-13 Thread Yabin Cui via Phabricator via cfe-commits
yabinc created this revision. Herald added a project: All. yabinc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to allow future clang versions and use of LLVM_VERSION_PATCH. Repository: rG LLVM Github Monorepo https://reviews