is as r247634.
This sounds good. I'll try to contact the people at Illumos interested
in this to see if they want to work with me on making that happen.
Thanks!
>
> Cheers,
> Rafael
>
>
>
> On 8 September 2015 at 09:47, Xan López via cfe-commits
> wrote:
> >
On Tue, Sep 08, 2015 at 03:28:12PM +0200, Joerg Sonnenberger via cfe-commits
wro> We don't distinguish Solaris and OpenSolaris forks currently. As such,
> changing one for the other is not a good choice, especially since you
> are more likely to find clang users for Illumos, IMO.
>
> https://www.
On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > What do you consider as recent Solaris? When I asked, I've been told
> > that Illumos has been providing __cxa_atexit since 2013. As such,
> > disabling it for the Solaris family by d
On Tue, Sep 08, 2015 at 01:09:02PM +0200, Joerg Sonnenberger via cfe-commits
wrote:
> On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> > There is no __cxa_finalize symbol available on recent Solaris OS
> > versions, so we need this flag to make non trivi
On Mon, Sep 07, 2015 at 02:44:23PM -0700, Saleem Abdulrasool wrote:
> > Right. Tried to explain a bit what's going on in the commit message,
> > with a reference to the original commit that removed the flag.
>
>
> Thanks. Would you like me to commit this on your behalf as well?
Yes please. Than
On Mon, Sep 07, 2015 at 10:38:08AM -0700, Saleem Abdulrasool wrote:
> The patch LGTM with a minor request for tweaking the commit message to have
> the context about the fact that cxa_finalize.o never shipped, and so this
> doesn't really cause any problems for older releases.
Right. Tried to expl
OK! So here's the patch with a test.
Xan
On Mon, Sep 07, 2015 at 09:14:05AM -0700, Saleem Abdulrasool wrote:
> On Mon, Sep 7, 2015 at 2:28 AM, Xan López wrote:
>
> > On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote:
> > > > Ping?
> > > >
> > >
> > > Does this break with older
On Mon, Sep 07, 2015 at 09:07:41AM -0700, Saleem Abdulrasool wrote:
> > Basically check that -lc is present when clang is called in a certain
> > way I guess? Or something more sophisticated?
>
>
> Yeah, that it is present when a DSO or executable is linked.
Right, maybe something like this. Pat
On Sat, Sep 05, 2015 at 12:28:43PM -0700, Saleem Abdulrasool wrote:
> > Ping?
> >
>
> Testcase? Looks fine otherwise.
Basically check that -lc is present when clang is called in a certain
way I guess? Or something more sophisticated?
Xan
>
>
> > > From 8e81d6b095542c0ff1e28cf1f09d675f8afe1a2
On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote:
> > Ping?
> >
>
> Does this break with older Solaris releases? How far back did this change
> in Solaris? The change itself should really be accompanied with a test.
Hi,
turns out I'm not really sure cxa_finalize.o was ever av
On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote:
> This is actually needed, otherwise libc won't be added at all. For
> instance when building libclang.so all the libc symbols won't be
> found, with ld warning about libc being an "implicit depend
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> There is no __cxa_finalize symbol available on recent Solaris OS
> versions, so we need this flag to make non trivial C++ programs run.
>
> Also stop looking for cxa_finalize.o, since it won't be there.
Oops, missed this. Here is the updated patch.
And yes please, commit the patch for me.
Cheers,
Xan
On Mon, Aug 31, 2015 at 01:07:35PM -0400, Rafael Espíndola wrote:
> Do you have a version with the last suggestions? I lgtmed it conditional on
> it. Do you need someone to commit it for you?
>
This is actually needed, otherwise libc won't be added at all. For
instance when building libclang.so all the libc symbols won't be
found, with ld warning about libc being an "implicit dependency".
((This patch sits on top of a couple of unreviewed patches that make clang
actually work on Solaris
There is no __cxa_finalize symbol available on recent Solaris OS
versions, so we need this flag to make non trivial C++ programs run.
Also stop looking for cxa_finalize.o, since it won't be there.
(This patch sits on top of a couple of unreviewed patches that make clang
actually work on Solaris,
Hi,
thanks for the review, I was not even aware that this could be
tested. Adding a test helped to fix me a couple extra issues (plus the
one you already mentioned). New patch attached.
Xan
On Wed, Aug 05, 2015 at 09:14:30AM -0400, Rafael Espíndola wrote:
> Please git-clang-format this patch.
>
16 matches
Mail list logo
