https://github.com/francisvm approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/83584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
francisvm wrote:
Maybe we can agree to not allow nested `<...>`, and it should simplify the
parsing a little?
https://github.com/llvm/llvm-project/pull/83584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/francisvm approved this pull request.
https://github.com/llvm/llvm-project/pull/82152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/francisvm approved this pull request.
https://github.com/llvm/llvm-project/pull/72647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1391,7 +1394,26 @@ class LowerMatrixIntrinsics {
return TTI.getMemoryOpCost(Instruction::Load, VecTy, Align(1), 0) -
N * TTI.getMemoryOpCost(Instruction::Load, EltTy, Align(1), 0);
};
-auto LHSCost = GetCostForArg(LHS, LShape.NumColumns);
+
--
@@ -1391,7 +1394,26 @@ class LowerMatrixIntrinsics {
return TTI.getMemoryOpCost(Instruction::Load, VecTy, Align(1), 0) -
N * TTI.getMemoryOpCost(Instruction::Load, EltTy, Align(1), 0);
};
-auto LHSCost = GetCostForArg(LHS, LShape.NumColumns);
+
--
thegameg created this revision.
thegameg added reviewers: djasper, mprobst, ioeric, klimek.
thegameg added a subscriber: cfe-commits.
c++1z adds the following constructions to the language:
if constexpr (cond)
statement1;
else if constexpr (cond)
statement2;
else if constexpr (cond)
st
thegameg added a comment.
Can you commit this for me, please? Thanks!
https://reviews.llvm.org/D23641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thegameg created this revision.
thegameg added reviewers: aaron.ballman, courbet.
thegameg added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The example is using `isInteger()` instead of `signed` / `unsigned` version.
https://reviews.llvm.org/D23641
Files:
docs/LibASTMatchers
thegameg added a comment.
Thank you for the review.
I don't have commit access, would you commit this for me, please?
Thanks!
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
thegameg updated this revision to Diff 68340.
thegameg added a comment.
Update documentation according to @aarnon.ballman's remarks.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unit
thegameg marked an inline comment as done.
thegameg added a comment.
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thegameg added a subscriber: alexfh.
thegameg updated this revision to Diff 68332.
thegameg added a comment.
LibASTMatchersReference.html regenerated using `dump_ast_matchers.py`.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.
thegameg marked an inline comment as done.
thegameg added a comment.
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thegameg updated this revision to Diff 68288.
thegameg added a comment.
Mention UniqueExternalLinkage type, add a test according to it.
`EXPECT_FALSE(matches(` -> `EXPECT_TRUE(notMatches(`
https://reviews.llvm.org/D23585
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/A
thegameg updated this revision to Diff 68290.
thegameg added a comment.
Sorry, sent the wrong patch.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNar
thegameg marked an inline comment as done.
thegameg added a comment.
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thegameg created this revision.
thegameg added reviewers: bkramer, alexfh, hokein.
thegameg added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Matches NamedDecl nodes whose linkage is external.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/
thegameg added a comment.
Thanks @vsk. As I don't have commit access, is it possible to commit this for
me, please? Thanks.
https://reviews.llvm.org/D23433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
thegameg created this revision.
thegameg added reviewers: joker-eph, vsk, dblaikie.
thegameg added a subscriber: cfe-commits.
The member function is a predicate, and doesn't apply any changes on the object.
https://reviews.llvm.org/D23433
Files:
include/clang/Basic/SourceManager.h
Index: incl
20 matches
Mail list logo
