[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

Tyker added a comment. This seems like a good change to me. but i don't think my approval is enough Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 ___ cfe-comm

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2393 InitScope.pop(); aaron.ballman wrote: > Is there a reason we're not moving this one to below > `AddInititializerToDecl()` as we did elsewhere? yes, It was causing a few test f

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 382702. Tyker added a comment. In D74130#3085313 , @aaron.ballman wrote: > FWIW, I am not seeing double errors on that code. Here's the output I get > with this patch applied locally: > > F:\source\llvm-project>cat "

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 381416. Tyker added a comment. In D74130#3073271 , @aaron.ballman wrote: > @Tyker -- are you planning to pick this review back up again sometime in the > near future? If not, do you care if the review gets commandeered

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. I added the changes to the langref in https://reviews.llvm.org/D96646 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 ___ cfe-commits maili

[PATCH] D91239: Update attribute example to fit the new Annotation API

Tyker added a comment. I recently made it much easier to create AnnotationAttr in this context with https://reviews.llvm.org/rGd093401a2617d3c46aaed9eeaecf877e3ae1a9f1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91239/new/ https://reviews.llvm.

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. In D88645#2353152 , @thakis wrote: > Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt > > Please take a look, and revert for now if it takes a while to fix. this is fixed by 4afa077899b

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3205bbca3e0: [Annotation] Allows annotation to carry some additional constant arguments. (authored by Tyker). Changed prior to commit: https://re

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 300213. Tyker added a comment. In D88645#2347731 , @aaron.ballman wrote: > In D88645#2347725 , @Tyker wrote: > >> In D88645#2347050 , @aa

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. In D88645#2347050 , @aaron.ballman wrote: > LGTM aside from a request for a comment to be added. Thank you! do you mean an RFC on llvm-dev/cfe-dev ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added a comment. In D63640#2339917 , @rsmith wrote: > In D63640#2331779 , @Tyker wrote: > >> but the "real" blocker is that the testing depends on D85144 >> for testing. >> w

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf34dd0c4e84: [clang] Improve Serialization/Imporing/Dumping of AP

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3706 + +if (!Result || !Notes.empty()) { + Diag(E->getBeginLoc(), diag::err_attribute_argument_n_type) aaron.ballman wrote: > I'm surprised that the presence of notes alone would me

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 299333. Tyker marked 4 inline comments as done. Tyker added a comment. Herald added a subscriber: dexonsmith. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 298818. Tyker marked 9 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74130/new/ https://reviews.llvm.org/D74130 Files: clang/include/clang/AS

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1026 + HandleImmediateInvocations(ExprEvalContexts.back()); + rsmith wrote: > What do we need this for? If I'm understanding the patch correctly, I think > the only way we should propagate immed

[PATCH] D74130: [clang] fix consteval call in default arguements

Tyker updated this revision to Diff 298344. Tyker retitled this revision from "[clang] fix consteval call in default arguements " to "[clang] fix consteval call in default arguements". Tyker added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebased and add mo

[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue

This revision was automatically updated to reflect the committed changes. Closed by commit rG53122ce2b39f: [NFC] Correct name of profile function to Profile in APValue (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D88643?vs=295502&id=298330#toc Repository: rG LLVM Gi

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added a comment. In D63640#2331734 , @martong wrote: > In D63640#2331410 , @rsmith wrote: > >> Reverse ping: I have a patch implementing class type non-type template >> parameters that's blocked on this landi

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 298318. Tyker added a comment. try to apply martongs's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/inc

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2229-2233 + SmallVector Args = { + AnnotatedVal, + Builder.CreateBitCast(CGM.EmitAnnotationString(AnnotationStr), Int8PtrTy), + Builder.CreateBitCast(CGM.EmitAnnotationUnit(Location),

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 297409. Tyker marked 11 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 Files: clang/include/clang/B

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3683 + auto *Attr = + AnnotateAttr::Create(Context, Str, Args.empty() ? nullptr : Args.data(), + Args.size(), CI.getRange(), CI.getSyntax()); aaron.ballman wr

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 297159. Tyker marked 7 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 Files: clang/include/clang/Ba

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:9010 + ToPath[Idx] = + cast(const_cast(ImpDecl.get())); +} rsmith wrote: > We want the path in an `APValue` to be canonical, but importing a canonical > decl might result in

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 295626. Tyker marked 15 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AS

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker created this revision. Tyker added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Tyker requested review of this revision. Herald added a subscriber: jdoerfert. This allows using annotation in a much more contexts than it c

[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker requested review of this revision. Capitalize the profile function of APValue such that it can be used by FoldingSetNodeID Repository: rG LLVM Github Monor

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker added a comment. i believe all known issues with this patch have been fixed is it fine to reland ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 ___ cfe-

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 285747. Tyker added a comment. In D85144#2205461 , @riccibruno wrote: > I agree with you that it's fine to use `printPretty` for leaves (and > additionally it would be annoying to duplicate the `LValue` case); that's

[PATCH] D85933: Don't track consteval references for dependent members

Tyker added a comment. thanks for this, here is a few comments aside from that this seems fine. Comment at: clang/lib/Sema/SemaOverload.cpp:1761 + llvm::SaveAndRestore DisableIITracking( + S.RebuildingImmediateInvocation, true); + I don't think R

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 283985. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 283984. Tyker marked an inline comment as done. Tyker added a comment. this a patch i had to improve dumping before your improvement to dumping. I think there is benefits to being able to dump APValues like LValues without an ASTContext even if the output will

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 282687. Tyker added a comment. remove unintended code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85144/new/ https://reviews.llvm.org/D85144 Files: clang/include/clang/AST/APValue.h clang/include/clang/AS

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result = ActOnFinishFullExpr(Init, VDecl->getLocation(), /*DiscardedValue*/ false, VDecl->isConstexpr()); rsmith wrote: > This may cre

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker created this revision. Tyker added reviewers: rsmith, riccibruno. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker requested review of this revision. this is required for proper testing of D63640 Repository: rG LLVM Github Mon

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 282682. Tyker edited the summary of this revision. Tyker added a comment. Sorry for the delay In D63640#2151016 , @rsmith wrote: > Are we at a point where we can test this now? Yes we can use consteval to test it. so i

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker). Repository: rG L

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 276500. Tyker added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/align_value.cpp

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 276498. Tyker added a comment. addressed commemt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/alig

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 275550. Tyker added a comment. fixed the issue with multiple align in a single assume. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenF

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc95ffadb2474: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/ne

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 272968. Tyker marked 2 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeG

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 272194. Tyker added a comment. sorry for not doing much recently. i split with an NFC patch with only test updates. and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bab88b7baa2: Prevent IR-gen from emitting consteval declarations (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D76420?vs=264238&id=270685#toc Repository: rG LLVM Github Mono

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker added a comment. In D71739#2048409 , @rjmccall wrote: > Is there a good reason for this to use the same `llvm.assume` intrinsic as > before? thee hasn't been any discussion i am aware of on this topic. but personally i think keeping the same intri

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264238. Tyker added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CG

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264237. Tyker added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGBlo

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6807-6808 +llvm::SaveAndRestore InConstantContext(Info.InConstantContext, true); return StmtVisitorTy::Visit(E->getSubExpr()); } rsmith wrote: > I don't think this is really rig

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264236. Tyker marked 12 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264023. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp clang/lib/AST/Ex

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

Tyker added a comment. In D71739#1961508 , @jdoerfert wrote: > @lebedev.ri We'd need to identify other uses of the alignment encoding > in-tree so we can replace them as well. Also, this patch uses not only the > alignment but also the offset in the ope

[PATCH] D76724: Prevent immediate evaluations inside of decltype

Tyker added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15389 if (!E.isUsable() || !Decl || !Decl->isConsteval() || isConstantEvaluated() || - RebuildingImmediateInvocation) + isInDeclType(*this) || RebuildingImmediateInvocation) return E;

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

Tyker added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1871 +llvm::Constant *CodeGenModule::EmitConstantValue(const APValue &Value, + QualType DestType, + CodeGe

[PATCH] D74007: [clang] Add support for consteval constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG180581cfcf51: [clang] Add support for consteval constructors (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D74130: [clang] fix consteval call in default arguements . with this patch instead of emitting calls to consteval function. the IR-gen

[PATCH] D76396: Allow immediate invocation of constructors

Tyker added a comment. thanks for the the patch, but I have already a patch aiming to do the same thing. D74007 > Provide improvements which allow the cached values of ConstantExpr to be used > by both the constant evaluator and code gen this is definitely som

[PATCH] D74418: [clang] fix error detection in consteval calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGca50f09db9f8: [clang] fix error detection in consteval calls (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker added a comment. In D71037#1871089 , @efriedma wrote: > I just ran into this warning, and I think there's a bit of a discoverability > problem related to the width of tabs and -ftabstop. If you have mixed tabs > and spaces, and you've correctly sp

[PATCH] D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation

Tyker added a comment. i tried to find a good message but i don't think i succeeded. any suggestions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75009/new/ https://reviews.llvm.org/D75009 ___ cfe-commits mailing l

[PATCH] D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation

Tyker created this revision. Tyker added a reviewer: eli.friedman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a comment. i tried to find a good message but i don't think i succeeded. any suggestions. This adds an additional note after the misleading warnin

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG008e7bf92343: [C++20] Add consteval-specific semantic for functions (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D63960?vs=232450&id=242391#toc Repository: rG LLVM Github Mo

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker marked 8 inline comments as done. Tyker added a comment. thank you for the review. i am sorry there were so many back and forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @aaron.ballman do you think you can review this ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith friendly reminder CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 236707. Tyker added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h

[PATCH] D72202: [Diagnostic] make Wmisleading-indendation not warn about labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5329bfc76bb: [Diagnostic] make Wmisleading-indendation not warn about labels (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. In D70638#1804138 , @aaron.ballman wrote: > In D70638#1803364 , @xbolva00 wrote: > > > (re-ping; I think this false positive for goto label case is important to > > be fixed before 10 releas

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker closed this revision. Tyker added a comment. In D71037#1803704 , @mstorsjo wrote: > In D71037#1803574 , @Tyker wrote: > > > In D71037#1803361 , @xbolva00 > > wrote: >

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker added a comment. In D71037#1803361 , @xbolva00 wrote: > Can you add a test case for that crash? Otherwise OK. as i said. the bug can only occur for one line files. so we can't have a run line and a the crashing line. so i wasn't able to make a tes

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker updated this revision to Diff 236058. Tyker added a comment. This update should fixes the issue. the assert was incorrect. because file offsets are 0-based where as column numbers are 1-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D7103

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47b35ff51b3: [Diagnostic] Add ftabstop to -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71083: [Diagnsotics] Small Improvement on -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Tyker marked an inline comment as done. Closed by commit rG9c8cfa09d762: [Diagnsotics] Small Improvement on -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. now that the issue with uniqueness of expressions is solved. we should be able to keep going on that review @rsmith. https://reviews.llvm.org/D63960 should be i think close to completion. so maybe for testing i could use immediate invocation as a source for ConstantExpr i

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 232450. Tyker marked 14 inline comments as done. Tyker added a comment. comments were fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/St

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13618 + if (InPlace) { +LValue LVal; +if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || rsmith wrote: > This isn't sufficient: the evaluation process can refer back to the obje

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. i have not tested the performance impact. but i tried to do the heavier checks last to minimize the impact. i added your tests file to the improvement commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. the warning was not affected by -ftabstop. i made a patch that fix this. https://reviews.llvm.org/D71037 and I agree that mixing tabs and space is a horrible idea for many reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked 6 inline comments as done. Tyker added a comment. i did a few test on the linux kernel on prior version of this patchs and the mix of spaces and tabs caused some false positives. but i do believe there is still a bug here. for the mix of space and tabs. gcc has a -ftabstop=//X// to

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc840b21e161: [Diagnostic] add a warning which warns about misleading indentation (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/ne

[PATCH] D70861: [NFCI] update formating for misleading indentation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9604727526: [NFCI] update formating for misleading indentation warning (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231949. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h clang

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231792. Tyker added a comment. improved based on aaron's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticPa

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7f6b439699: [clang][modules] Add support for merging lifetime-extended temporaries (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 231589. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Serialization/ASTReader.h clang/lib/AST/TextN

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231585. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h clang

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1376 + +MIChecker.Check(ElseStmt.isUsable()); Tyker wrote: > xbolva00 wrote: > > What is wrong with code you used some rev ago? > > > > if (usabl

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1376 + +MIChecker.Check(ElseStmt.isUsable()); xbolva00 wrote: > What is wrong with code you used some rev ago? > > if (usable) check(); > > Now

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231584. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h clang

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231583. Tyker added a comment. Improve the warning for else if CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParse

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231561. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h clang

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231545. Tyker added a comment. I just found out that `Parser::isCXXDeclarationStatement` is does more then just disambiguation it can emit diagnostics. which can cause error on correct code. so we can't use it in this context to disambiguate. so it is not pos

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231534. Tyker added a comment. yeah i saw. this version of the patch builds all llvm subproject(not tested on llgo) without warnings. there is only one case in llvm's code in which this warning is more agressive thant GCC's. if (1) i = 0; // commen

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. Thanks for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b86188b50bf: [Diagnostic] add a warning which warns about misleading indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 230790. Tyker added a comment. rebased added new lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/cla

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >