[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

jtony added inline comments. Comment at: test/Driver/ppc-features.cpp:140 + // RUN: %clang -target powerpc64-unknown-linux-gnu %s -mno-htm -### -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-NOHTM %s // CHECK-NOHTM: "-target-feature" "-htm" We probably need to a

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

This revision was automatically updated to reflect the committed changes. jtony marked 2 inline comments as done. Closed by commit rL303760: [PowerPC] Implement vec_xxpermdi builtin. (authored by jtony). Changed prior to commit: https://reviews.llvm.org/D33053?vs=99966&id=100093#toc Repository

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony updated this revision to Diff 99966. https://reviews.llvm.org/D33053 Files: include/clang/Basic/BuiltinsPPC.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/CodeGen/CGBuiltin.cpp lib/Headers/altivec.h lib/Sema/SemaChecking.cpp test/CodeGen/builtins-

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony updated this revision to Diff 99955. jtony marked 6 inline comments as done. jtony added a comment. Address more comments from Nemanja and Hiroshi. https://reviews.llvm.org/D33053 Files: include/clang/Basic/BuiltinsPPC.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sem

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3900 +// vector short vec_xxsldwi(vector short, vector short, int); +bool Sema::SemaBuiltinVSX(CallExpr *TheCall, unsigned NumArgs) { + if (TheCall->getNumArgs() < NumArgs) nemanjai wrote: > I as

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony updated this revision to Diff 99292. jtony added a comment. Address all the comments from Nemanja. https://reviews.llvm.org/D33053 Files: include/clang/Basic/BuiltinsPPC.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/CodeGen/CGBuiltin.cpp lib/Header

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony marked 6 inline comments as done. jtony added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8433 +if (getTarget().isLittleEndian()) { + switch (Index) { + case 0: nemanjai wrote: > The switch is overkill. You should just implement thi

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

jtony created this revision. The vec_xxpermdi builtin is missing from altivec.h. This has been requested by developers working on libvpx for VP9 support for Google. Initially, I tried to define a new intrinsic to map it to the corresponding PowerPC hard instruction (XXPERMDI) directly. But the

[PATCH] D28528: [PowerPC] [PowerPC] Fix the wrong implementation of builtin vec_rlnm.

jtony created this revision. jtony added reviewers: nemanjai, kbarton, sfertile, lei, syzaara. jtony added subscribers: llvm-commits, cfe-commits, hfinkel, echristo. vec_rlnm was implemented according to the old ABI, which was wrong. The ABI team have fixed the issue (although not published yet).

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

jtony added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:800 - void makeLargest(bool Neg) { getIEEE().makeLargest(Neg); } + void makeLargest(bool Neg) { +if (usesLayout(getSemantics())) { I know it is allowed to return a void function call

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

jtony added inline comments. Comment at: lib/Headers/altivec.h:16456 #ifdef __VSX__ static __inline__ vector signed long long __ATTRS_o_ai Thanks a lot for your good catch for the macro issue in vec_xst_be, that's a good catch. BTW, Can you move this up als