allevato added a comment.
Oh, and in case I need to mention this (I don't contribute to llvm/clang
frequently), I don't have commit access so I'll need someone else to merge it
in. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60161/new/
allevato marked 2 inline comments as done.
allevato added a comment.
Thanks for the review! This is ready to go on my end if there aren't any other
comments.
Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:845
+ // actually use them (it overwrites them with the addresses
allevato updated this revision to Diff 194530.
allevato added a comment.
- Rename generate* to get* and cleanup param names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60161/new/
https://reviews.llvm.org/D60161
Files:
clang/include/clang/Code
allevato updated this revision to Diff 194379.
allevato added a comment.
- Apply review changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60161/new/
https://reviews.llvm.org/D60161
Files:
clang/include/clang/CodeGen/CodeGenABITypes.h
clang
allevato added inline comments.
Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93
+llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst,
+CharUnits Alignment, QualType QT);
+
rjmccall wrote:
> Hmm. I think it might be better to just have t
allevato created this revision.
allevato added a reviewer: rjmccall.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.
This change exposes the helper functions that generate ctors/dtors
for non-trivial structs so that they can be called from the Swift
compiler (see h
