[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz updated this revision to Diff 191540. to-miz added a comment. Made a new diff on the git repository, since the docs now recommend using git. Rebased and created a new diff with `git show HEAD -U99`. The patch applies cleanly on windows after `git reset --hard` so I hope there shouldn't

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. I checked out the git repository and applied the patch to head and reran all tests. The diff produced by git is basically the same, should I upload the new diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. Is it because the diff was made with the svn repository? It is for the newest revision. Should I make a new diff with the git repo instead? Or is it not because of the diff, but something in phabricator instead? Sorry this is my first patch. CHANGES SINCE LAST ACTION h

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. I don't have commit access. It would be nice if someone could commit it in my place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___ cfe-commits mailing list cfe-commits@

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz updated this revision to Diff 189048. to-miz added a comment. Added an entry to ReleaseNotes.rst about the new option. This diff doesn't contain unrelated formatting changes due to running clang-format on some source files that apparently weren't formatted before. CHANGES SINCE LAST ACTI

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. I understand that adding new options adds costs to the development of clang-format, but there was a feature request and there is interest for this option. As for the cost to the development, there already exists PPDIS_AfterHash. All I did was make the changes introduced

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz updated this revision to Diff 165700. to-miz added a comment. PPBranchLevel can be negative, while Line->Level is unsigned. Added check to ensure that PPBranchLevel is positive before adding to Line->Level. https://reviews.llvm.org/D52150 Files: docs/ClangFormatStyleOptions.rst incl

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz created this revision. to-miz added reviewers: djasper, klimek, krasimir, sammccall, mprobst, Nicola. Herald added a subscriber: cfe-commits. The option BeforeHash added to IndentPPDirectives. Fixes Bug 36019. Repository: rC Clang https://reviews.llvm.org/D52150 Files: docs/ClangFor