snidertm added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:1882
+ if (FI.isCmseNSCall())
+FuncAttrs.addAttribute("cmse_nonsecure_call");
+
Just curious … Does the LLVM backend have a way to extract a StringRef
attribute from a CallInst? I know
snidertm added a comment.
Have you already committed support for CMSE attributes to the LLVM backend? Or
is that on the way?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71129/new/
https://reviews.llvm.org/D71129
__
snidertm added inline comments.
Comment at: clang/include/clang/AST/Type.h:3622
bool getNoCfCheck() const { return Bits & NoCfCheckMask; }
bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; }
chill wrote:
> snidertm wrote:
> > chill wro
snidertm added inline comments.
Comment at: clang/include/clang/AST/Type.h:3604
+ (noCallerSavedRegs ? NoCallerSavedRegsMask : 0) |
+ (hasRegParm ? ((regParm + 1) << RegParmOffset) : 0) |
+ (NoCfCheck ? NoCfCheckMask : 0) |
Wou
snidertm added inline comments.
Comment at: clang/include/clang/AST/Type.h:3588
+ NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask),
RegParmOffset = 8
}; // Assumed to be the last field
Shouldn't RegParmOffset be updated to
snidertm added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:438
+} else if (Feature == "+8msecext") {
+ if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+Diags.Report(diag::err_target_unsupported_mcmse) << CPU;
dmgree
snidertm added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:438
+} else if (Feature == "+8msecext") {
+ if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+Diags.Report(diag::err_target_unsupported_mcmse) << CPU;
How do
