[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-06-19 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. That is perfectly fine. I just wanted to let you know that we are still interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 __

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-05-27 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Herald added subscribers: bviyer, asb. @nhaehnle, I wanted to check in briefly if you are getting the same error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 ___

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-21 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. I just checked and I get the same error on a linux system. @nhaehnle, did you try an mlir build with the previously mentioned cmake options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.or

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-21 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. This patch overcomes the issue of cl options being defined multiple times. That is great! I just tried it on Windows on top of e7fb6c394f519d6e6812f1fbbff1571d5e51f5c4 with (msys2), as well as LLVM_L

[PATCH] D41412: [libcxx] implement concat() and split()

2019-08-17 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Herald added a subscriber: sanjoy.google. @ericwf and @timshen, @Maxf and I are indeed very interested in seeing this library upstreamed soon. Over the last weeks, we developed a software prototype based on these bindings and already started to tune performance on clang/

[PATCH] D41412: [libcxx] implement concat() and split()

2019-07-25 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. @EricWF thanks again for offering your help here. We are not in a rush here, but I wonder if you happen to have a rough estimate when you might have the time to look into these patches? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.l

[PATCH] D41412: [libcxx] implement concat() and split()

2019-07-19 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. In D41412#1592152 , @timshen wrote: > Tobias, > > I spoke to @EricWF who is willing to take a look at all these patches. > However, I don't know when exactly will the review starts. Amazing. I am super interested in seeing this

[PATCH] D41412: [libcxx] implement concat() and split()

2019-07-18 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. It seems this patch went through at least one review and the only open comment is the discussion if __builtin_shuffle should be placed in the configuration. From my perspective, both solutions are technically feasible. While it seems unlikely that gcc will gain this spe

[PATCH] D41412: [libcxx] implement concat() and split()

2019-07-15 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Hi @timshen, I am very interested in these patches. Any chance you can take up the upstreaming process again? Best, Tobias CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.llvm.org/D41412

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

2017-06-01 Thread Tobias Grosser via Phabricator via cfe-commits
grosser created this revision. Herald added subscribers: javed.absar, wdng. Today 'const' functions are only marked 'readnone' and 'nounwind', but lack the 'speculatable' attribute for historic reasons. As 'const' functions are known to not have any side effects and are intended to enable loop opt