[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

https://github.com/tcreech-intel approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/117282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

@@ -2660,7 +2660,7 @@ usual build cycle when using sample profilers for optimization: > clang-cl /O2 -gdwarf -gline-tables-only ^ /clang:-fdebug-info-for-profiling /clang:-funique-internal-linkage-names ^ - /fprofile-sample-use=code.prof code.cc /Fe:code /f

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

https://github.com/tcreech-intel edited https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

tcreech-intel wrote: Yes, the article you link to is highly relevant. Without this PR we're hitting the problem described in example #4. We can promote the issue to a build failure by choosing a custom command which can't run concurrently with itself: ```cmake cmake_minimum_required(VERSION 3.

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/95018 >From 3e85695cc62abf8fe0943421708b5db67750b4ea Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 10 Jun 2024 11:07:55 -0400 Subject: [PATCH 1/2] [libclc] Improve dependencies to avoid build errors With

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

https://github.com/tcreech-intel edited https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Improve dependencies to avoid build errors (PR #95018)

https://github.com/tcreech-intel created https://github.com/llvm/llvm-project/pull/95018 With the Makefile generator and particularly high build parallelism some intermediate dependencies may be generated redundantly and concurrently, leading to build failures. To fix this, arrange for libclc

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

@@ -2547,22 +2547,40 @@ usual build cycle when using sample profilers for optimization: used in the first step. The only requirement is that you build the code with the same debug info options and ``-fprofile-sample-use``. + On Linux: + .. code-block:: console

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/88438 >From fe3404cbdf78b434f16f8351dc242175b4543112 Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Thu, 11 Apr 2024 16:03:52 -0400 Subject: [PATCH 1/4] Improve documented sampling profiler steps to best known

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/88438 >From fe3404cbdf78b434f16f8351dc242175b4543112 Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Thu, 11 Apr 2024 16:03:52 -0400 Subject: [PATCH 1/3] Improve documented sampling profiler steps to best known

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/88438 >From fe3404cbdf78b434f16f8351dc242175b4543112 Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Thu, 11 Apr 2024 16:03:52 -0400 Subject: [PATCH 1/2] Improve documented sampling profiler steps to best known

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

@@ -2443,27 +2443,29 @@ usual build cycle when using sample profilers for optimization: usual build flags that you always build your application with. The only requirement is that DWARF debug info including source line information is generated. This DWARF information

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

tcreech-intel wrote: @williamweixiao, @HaohaiWen, this updates the docs to describe best practices given #83972. It seems `-fdebug-info-for-profiling` can be particularly important. Without it we were discarding nearly half of the samples in some cases. https://github.com/llvm/llvm-project/pu

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

https://github.com/tcreech-intel ready_for_review https://github.com/llvm/llvm-project/pull/88438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

https://github.com/tcreech-intel created https://github.com/llvm/llvm-project/pull/88438 1. Add `-fdebug-info-for-profiling -funique-internal-linkage-names`, which improve the usefulness of debug info for profiling. 2. Recommend the use of `br_inst_retired.near_taken:uppp`, which provides the

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

tcreech-intel wrote: > please resolve the conflicts. Thanks for the review, @williamweixiao. I've resolved the conflicts in 2312821. https://github.com/llvm/llvm-project/pull/84864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/84864 >From 4dc108d0d290ee5fd6a73c029c051fdb2215d00a Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 11 Mar 2024 22:35:59 -0400 Subject: [PATCH 1/5] Update documentation and release notes for llvm-profgen C

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2454,7 +2481,14 @@ usual build cycle when using sample profilers for optimization: .. code-block:: console - $ llvm-profgen --binary=./code --output=code.prof--perfdata=perf.data + $ llvm-profgen --binary=./code --output=code.prof --perfdata=perf.data + + Wh

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/84864 >From 4dc108d0d290ee5fd6a73c029c051fdb2215d00a Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 11 Mar 2024 22:35:59 -0400 Subject: [PATCH 1/5] Update documentation and release notes for llvm-profgen C

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

https://github.com/tcreech-intel ready_for_review https://github.com/llvm/llvm-project/pull/84864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2410,20 +2410,35 @@ usual build cycle when using sample profilers for optimization: 1. Build the code with source line table information. You can use all the usual build flags that you always build your application with. The only - requirement is that you add ``-glin

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2410,20 +2410,35 @@ usual build cycle when using sample profilers for optimization: 1. Build the code with source line table information. You can use all the usual build flags that you always build your application with. The only - requirement is that you add ``-glin

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2410,20 +2410,35 @@ usual build cycle when using sample profilers for optimization: 1. Build the code with source line table information. You can use all the usual build flags that you always build your application with. The only - requirement is that you add ``-glin

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2434,6 +2449,15 @@ usual build cycle when using sample profilers for optimization: it provides better call information, which improves the accuracy of the profile data. + When using SEP: + + .. code-block:: console + + $ sep -start -ec BR_INST_RETIRED.NEAR_T

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/84864 >From 4dc108d0d290ee5fd6a73c029c051fdb2215d00a Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 11 Mar 2024 22:35:59 -0400 Subject: [PATCH 1/4] Update documentation and release notes for llvm-profgen C

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

@@ -2434,6 +2449,15 @@ usual build cycle when using sample profilers for optimization: it provides better call information, which improves the accuracy of the profile data. + When using SEP: + + .. code-block:: console + + $ sep -start -ec BR_INST_RETIRED.NEAR_T

[clang] [llvm] Update documentation and release notes for llvm-profgen COFF support (PR #84864)

https://github.com/tcreech-intel created https://github.com/llvm/llvm-project/pull/84864 This change: - Updates the existing Clang User's Manual section on SPGO so that it describes how to use llvm-profgen to perform SPGO on Windows. This is new functionality implemented in #83972. - Fixes a m