[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Hi there, Yes, sorry for the long silence, I ended up not having time to come back to this anymore for personal reasons. I also lack familiarity with the codebase and tests, and I couldn't invest more time into it; I had the impression that this last failing test would r

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 258029. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/F

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 257970. tnorth added a comment. Sorry. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/docs/Release

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping @MyDeveloperDay , any clue about what's going on here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing lis

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 249616. tnorth added a comment. Rebased on master (6d5603e2 ). Some refactoring was indeed needed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Thanks @MyDeveloperDay . I guess more approvals are needed at this point? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth marked 2 inline comments as done. tnorth added inline comments. Comment at: include/clang/Format/Format.h:2341 /// directory if ``FileName`` is empty. +/// * "file=" to explicitly specify the configuration file to use. /// lebedev.ri wrote: > So is it `:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 245592. tnorth added a comment. Fix comment to file: instead of the incorrect file= Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: docs/ClangFormat.rst docs/ClangFormatStyl

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. I guess we need more approval to go forward? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 241155. tnorth added a comment. - Add release notes - Update ClangFormat.rst and ClangFormatStyleOption.rst Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: docs/ClangFormat.rs

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. In D72326#1845342 , @MyDeveloperDay wrote: > Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst > (if there are any changes because you modified Format.h). Hmm, I tried to run docs/tools/dump_format_st

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth marked 7 inline comments as done. tnorth added a comment. > This makes sense for command-line args, but if I understand correctly this > patch will also allow BasedOnStyle: file:some/path. Is that the case? No, it should not, and I also think it's better not to. I think that all points a

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 240888. tnorth added a comment. - Add a unit-test loading a format and test file from temporary files. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: include/clang/Format/For

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 238513. tnorth added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thanks for your time and feedback. - Update diff with context, - remove public declaration of LoadConfigFile, - change prototype of LoadConfigFile and simpli