tatyana-krasnukha added a comment.
I'm not familiar with the z/OS target, so I cannot check the correctness of the
target-specific changes. The overall patch looks good.
Comment at: clang/lib/Basic/Targets/OSTargets.h:780
+public:
+ ZOSTargetInfo(const llvm::Triple &Triple, c
tatyana-krasnukha updated this revision to Diff 175290.
tatyana-krasnukha added a comment.
Minor change: remove splitting big numeric arguments on 32-bit integers.
Backend lowering code does this work.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53100/new/
htt
tatyana-krasnukha created this revision.
tatyana-krasnukha added a reviewer: petecoup.
tatyana-krasnukha added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
tatyana-krasnukha added a dependency: D53100: clang: Add ARCTargetInfo.
This option affects registers count for passing ar
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: petecoup, rjmccall, rsmith.
tatyana-krasnukha added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
This patch is an updated version of https://reviews.llvm.org/D43089 with
changes in arguments classifyin
tatyana-krasnukha added a comment.
Sorry, =default is not applicable in these cases, of course.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123
+public:
+ ARCABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+
tatyana-krasnukha wrote:
> Better use
tatyana-krasnukha added a comment.
This is what I could note
Comment at: clang/lib/Basic/Targets/ARC.h:26
+class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo {
+ static const Builtin::Info BuiltinInfo[];
+
Looks like unused member, while getTarget
tatyana-krasnukha added a comment.
Hello Pete,
Thank you for upstreaming ARC target to clang! I checked it in couple with lldb
- works well. So, the revision is good to me. But it seems, I have no rights to
accept revisions yet...
https://reviews.llvm.org/D43089
___
