SLTozer wrote:
I 'm not sure I agree with the principle of this change; the current behaviour
of not getting a DebugLoc when setting the insertion point to the end of a
BasicBlock is long-standing and this change might have unexpected knock-on
effects (although if we do make this change, it mu
@@ -5492,6 +5486,14 @@ void Verifier::visitInstruction(Instruction &I) {
if (MDNode *N = I.getDebugLoc().getAsMDNode()) {
CheckDI(isa(N), "invalid !dbg metadata attachment", &I, N);
visitMDNode(*N, AreDebugLocsAllowed::Yes);
+
+if (auto *DL = dyn_cast(N)) {
+
@@ -7,6 +7,8 @@
define dso_local void @f() !dbg !10 {
entry:
+; include non-key location to check verifier is checking the whole function.
SLTozer wrote:
```suggestion
; Include non-key location to check verifier is checking the whole function.
```
https://g
https://github.com/SLTozer approved this pull request.
LGTM with some inline nits.
https://github.com/llvm/llvm-project/pull/149043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/149043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
So just to makes sure my understanding is correct: we have an existing bug and
an existing test which should exercise that bug, but the verifier doesn't catch
it currently. This patch then fixes both the verifier and the bug, and
therefore a new test isn't needed for the non-ver
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/146521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
> Can you explain how the include helps in a bit more detail? I don't see what
> it adds (I'm not very familiar with llvm-config!)
It changes nothing now, but llvm-config contains the macro definition used here
- adding the include explicitly ensures that we don't silently lose
https://github.com/SLTozer created
https://github.com/llvm/llvm-project/pull/146521
In a previous commit, the llvm-config-defined macro
LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING was renamed to
LLVM_ENABLE_DEBUGLOC_TRACKING_COVERAGE. One instance of this in Clang remains
unchanged; this patch ren
SLTozer wrote:
> I think this functionality will also help identify passes which drop debug
> information and help with [the work proposed in this
> RFC](https://discourse.llvm.org/t/rfc-require-real-or-annotated-source-locations-on-all-instructions/86816).
As it happens, I have been using a d
Author: Stephen Tozer
Date: 2025-06-19T16:22:50+01:00
New Revision: 36af7345dfb8e84a1f2971db34089b63321e8467
URL:
https://github.com/llvm/llvm-project/commit/36af7345dfb8e84a1f2971db34089b63321e8467
DIFF:
https://github.com/llvm/llvm-project/commit/36af7345dfb8e84a1f2971db34089b63321e8467.diff
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
Closed in favour of a new patch stack for the same feature starting at:
https://github.com/llvm/llvm-project/pull/143590
https://github.com/llvm/llvm-project/pull/108214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/108214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1509,6 +1516,10 @@ CodeGenFunction::EmitCXXForRangeStmt(const
CXXForRangeStmt &S,
EmitStmt(S.getBody());
}
+ // The last block in the loop's body (which unconditionally branches to
theAdd commentMore actions
+ // `inc` block if there is one).
SLT
https://github.com/SLTozer approved this pull request.
LGTM with some nits.
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,87 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -gkey-instructions %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s
+
+// Perennial question: should the inc be its own source atom or not
+// (currently it is).
+
+// FIXME: See do.c and
https://github.com/SLTozer approved this pull request.
https://github.com/llvm/llvm-project/pull/134651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4466,7 +4473,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl
GD, unsigned BuiltinID,
Value *SizeVal = EmitScalarExpr(E->getArg(2));
EmitNonNullArgCheck(Dest, E->getArg(0)->getType(),
E->getArg(0)->getExprLoc(), FD, 0);
-Bui
https://github.com/SLTozer approved this pull request.
https://github.com/llvm/llvm-project/pull/141607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,77 @@
+
+// RUN: %clang_cc1 -gkey-instructions -x c++ %s
-debug-info-kind=line-tables-only -gno-column-info -emit-llvm -o -
-ftrivial-auto-var-init=zero -fenable-matrix -disable-llvm-passes \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/134651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer approved this pull request.
https://github.com/llvm/llvm-project/pull/134649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -gkey-instructions %s -debug-info-kind=line-tables-only
-emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
SLTozer wrote:
Maybe a small comment to the effect of, "Test fo
https://github.com/SLTozer approved this pull request.
https://github.com/llvm/llvm-project/pull/134648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1448,7 +1448,14 @@ CodeGenFunction::EmitCXXForRangeStmt(const
CXXForRangeStmt &S,
if (!Weights && CGM.getCodeGenOpts().OptimizationLevel)
BoolCondVal = emitCondLikelihoodViaExpectIntrinsic(
BoolCondVal, Stmt::getLikelihood(S.getBody()));
- Builder.CreateCond
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,71 @@
+// RUN: %clang_cc1 -gkey-instructions %s -debug-info-kind=line-tables-only
-emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// Perennial quesiton: should the inc be its own source atom or not
@@ -0,0 +1,71 @@
+// RUN: %clang_cc1 -gkey-instructions %s -debug-info-kind=line-tables-only
-emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// Perennial quesiton: should the inc be its own source atom or not
+// (current
https://github.com/SLTozer commented:
Broadly LGTM, just a few style comments.
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Stephen Tozer
Date: 2025-04-30T11:39:29+01:00
New Revision: 92195f6fc873cd27a5aa0852252dfe44ccdc6ea0
URL:
https://github.com/llvm/llvm-project/commit/92195f6fc873cd27a5aa0852252dfe44ccdc6ea0
DIFF:
https://github.com/llvm/llvm-project/commit/92195f6fc873cd27a5aa0852252dfe44ccdc6ea0.diff
Author: Stephen Tozer
Date: 2025-04-25T12:55:10+01:00
New Revision: 2dc6e98169baeb1f73036da0ea50fd828d8323d0
URL:
https://github.com/llvm/llvm-project/commit/2dc6e98169baeb1f73036da0ea50fd828d8323d0
DIFF:
https://github.com/llvm/llvm-project/commit/2dc6e98169baeb1f73036da0ea50fd828d8323d0.diff
SLTozer wrote:
> I did some downstream testing with "-Og" since this patch and noticed that
> e.g.
Thanks for catching these - in terms of legalizer support it looks like
everything relevant is implemented except for `SoftenFloatOperand`, so that
should be a straightforward fix. The target-sp
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/136867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/136867
>From 90c09c8326077a1ba6797519bbefd014f32b5beb Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 23 Apr 2025 14:24:50 +0100
Subject: [PATCH 1/5] [Clang] Emit Fake Uses before musttail calls
Fixes the issu
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/136867
>From 90c09c8326077a1ba6797519bbefd014f32b5beb Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 23 Apr 2025 14:24:50 +0100
Subject: [PATCH 1/4] [Clang] Emit Fake Uses before musttail calls
Fixes the issu
SLTozer wrote:
> Hi, I believe this merge is breaking external projects because you added
> `#include "llvm/Config/config.h"` which is not available (see comments at the
> top of that file).
Reverted for now, will look into relanding without the inclusion issue later.
https://github.com/llvm/
Author: Stephen Tozer
Date: 2025-04-25T00:36:28+01:00
New Revision: fdbf073a86573c9ac4d595fac8e06d252ce1469f
URL:
https://github.com/llvm/llvm-project/commit/fdbf073a86573c9ac4d595fac8e06d252ce1469f
DIFF:
https://github.com/llvm/llvm-project/commit/fdbf073a86573c9ac4d595fac8e06d252ce1469f.diff
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/107279
>From 55115af37710a80abbc2ec2ca5d96d1eea5827b4 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 4 Sep 2024 12:23:52 +0100
Subject: [PATCH 1/6] Add conditionally-enabled DebugLocKinds
---
clang/lib/CodeG
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/136867
>From 90c09c8326077a1ba6797519bbefd014f32b5beb Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 23 Apr 2025 14:24:50 +0100
Subject: [PATCH 1/3] [Clang] Emit Fake Uses before musttail calls
Fixes the issu
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/136867
>From 90c09c8326077a1ba6797519bbefd014f32b5beb Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 23 Apr 2025 14:24:50 +0100
Subject: [PATCH 1/2] [Clang] Emit Fake Uses before musttail calls
Fixes the issu
@@ -169,6 +169,47 @@ See the discussion in the section about
:ref:`merging locations` for examples of when the rule for
dropping locations applies.
+.. _NewInstLocations:
+
+Setting locations for new instructions
+--
+
+Whenever a new instru
SLTozer wrote:
> Any ideas why we might be hitting this issue? This happens during a built
> with `-Og`, and issue does not remove if I remove `-Og` flag.
At a glance that looks like it could be related, we generate (no-op) cleanup as
part of -fextend-variable-liveness. I'll look into this, bu
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/107279
>From 55115af37710a80abbc2ec2ca5d96d1eea5827b4 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 4 Sep 2024 12:23:52 +0100
Subject: [PATCH 1/4] Add conditionally-enabled DebugLocKinds
---
clang/lib/CodeG
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/107279
>From 55115af37710a80abbc2ec2ca5d96d1eea5827b4 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 4 Sep 2024 12:23:52 +0100
Subject: [PATCH 1/3] Add conditionally-enabled DebugLocKinds
---
clang/lib/CodeG
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/118026
>From c0369e1b36594d5d6f6c29d7ebb7319d79edf55b Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Thu, 28 Nov 2024 13:53:20 +
Subject: [PATCH 1/2] Enable -fextend-lifetimes at -Og
---
clang/docs/CommandGui
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/118026
>From 351971bbff4e77b0f36cd92cd1a881584d17a9e7 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Thu, 28 Nov 2024 13:53:20 +
Subject: [PATCH 1/2] Enable -fextend-lifetimes at -Og
---
clang/docs/CommandGui
SLTozer wrote:
> Is this ready to go? I can't recall if we ultimately accepted the RFC.
My interpretation of the RFC is that there was a general acceptance of `-Og =
-O1 + -fextend-variable-liveness`, so with the acceptance here I believe this
is ready!
https://github.com/llvm/llvm-project/pu
SLTozer wrote:
> It would be great to also have some documentation that shows step by step how
> you've used these abilities to find the bugs you've found.
SGTM - I think that should come in a separate patch. I have a branch with all
my changes on it (not stable, I rebase semi-regularly)
[her
SLTozer wrote:
> IIRC, there are still some open review threads in this PR, mainly related to
> reducing duplication in the symbolication bits.
Yes, this part won't land quite yet; as I'm kicking these reviews back into
action, I'll be pushing up some other reviews to come before this one in t
@@ -1837,13 +1837,13 @@ attributes #2 = { nounwind "target-cpu"="tahiti" }
!llvm.module.flags = !{!0}
!0 = !{i32 1, !"amdhsa_code_object_version", i32 500}
;.
-; HSA: attributes #[[ATTR0:[0-9]+]] = { nounwind }
+; HSA: attributes #[[ATTR0:[0-9]+]] = { nocallback nofree nosync n
@@ -113,6 +113,8 @@ static void substituteOperandWithArgument(Function *OldF,
for (Use *Op : OpsToReplace)
UniqueValues.insert(Op->get());
+ // TODO: Preserve range metadata with ranges
+
SLTozer wrote:
Unrelated change sneaking in?
https://github.com
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/131743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer approved this pull request.
Some minor comments, LGTM once addressed.
https://github.com/llvm/llvm-project/pull/131743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/110102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
I made a mistake and missed one of the tests in the fix-forward commit - the
[build with the fix
commit](https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8724466517233166081/overview)
only recently finished, so I've pushed up a second fix now -
Author: Stephen Tozer
Date: 2025-01-28T22:51:30Z
New Revision: 548ecde42886149dd4d69366d7c2dc02076a7083
URL:
https://github.com/llvm/llvm-project/commit/548ecde42886149dd4d69366d7c2dc02076a7083
DIFF:
https://github.com/llvm/llvm-project/commit/548ecde42886149dd4d69366d7c2dc02076a7083.diff
LOG:
SLTozer wrote:
> Commented on the commit but I'm not sure if that sends notifications.
I saw it, thanks - I'll likely update the tests afterwards, though for now I'm
keeping an eye on the bots/merge to make sure things turn/stay green.
https://github.com/llvm/llvm-project/pull/110102
___
Author: Stephen Tozer
Date: 2025-01-28T19:34:41Z
New Revision: de9b0ddedc43302117b15518ca21f3341cf6b5ff
URL:
https://github.com/llvm/llvm-project/commit/de9b0ddedc43302117b15518ca21f3341cf6b5ff
DIFF:
https://github.com/llvm/llvm-project/commit/de9b0ddedc43302117b15518ca21f3341cf6b5ff.diff
LOG:
SLTozer wrote:
I think the forward fix has been identified, and importantly it will take a bit
longer to revert than to submit the fix (adding triples to the tests), because
there are 4 commits that need to be reverted and I need to run a quick build to
ensure that nothing is broken by the rev
SLTozer wrote:
Apologies, I didn't expect this PR to trigger a failure and didn't catch the
triggered failures; thank you for catching this so quickly!
https://github.com/llvm/llvm-project/pull/124767
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/124767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
With the prior patches having landed, this is now in a state where it could
land; I've rebased it onto main, meaning all of the code diff in this PR is now
relevant.
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mail
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/124767
>From 3afa9cafe2f39ae28dd0c017c9dcd00dc6656143 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Tue, 28 Jan 2025 15:22:22 +
Subject: [PATCH 1/2] [Clang][LLVM] Cleanup docs and comments relating to
-fexten
https://github.com/SLTozer created
https://github.com/llvm/llvm-project/pull/124767
This patch contains a number of changes relating to the above flag; primarily
it updates comment references to the old flag names, "-fextend-lifetimes" and
"-fextend-this-ptr" to refer to the new names,
"-fext
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/118026
>From beb5e1955f9b0aa106512bb10d4543232e4d4cfa Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Thu, 28 Nov 2024 13:53:20 +
Subject: [PATCH] Enable -fextend-lifetimes at -Og
---
clang/docs/CommandGuide/c
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/110102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
Looks like the fix commit is passing everywhere, marking this one closed by
[4424c44c](https://github.com/llvm/llvm-project/commit/4424c44c8c4ec8e071f5c5999fba216d36fb92c9)
and
[8ad9e1e](https://github.com/llvm/llvm-project/commit/8ad9e1ecb7e565c2f99b4ef67517d1f37d1c80d0).
http
SLTozer wrote:
Pushed up a fix-forward commit,
[8ad9e1e](https://github.com/llvm/llvm-project/commit/8ad9e1ecb7e565c2f99b4ef67517d1f37d1c80d0),
that should fix the above issues; if issues still remain, I'll revert and
recommit after fixing offline.
https://github.com/llvm/llvm-project/pull/11
Author: Stephen Tozer
Date: 2025-01-28T13:21:41Z
New Revision: 8ad9e1ecb7e565c2f99b4ef67517d1f37d1c80d0
URL:
https://github.com/llvm/llvm-project/commit/8ad9e1ecb7e565c2f99b4ef67517d1f37d1c80d0
DIFF:
https://github.com/llvm/llvm-project/commit/8ad9e1ecb7e565c2f99b4ef67517d1f37d1c80d0.diff
LOG:
SLTozer wrote:
As with the previous commit #11, this has been merged in
[4424c44c](https://github.com/llvm/llvm-project/commit/4424c44c8c4ec8e071f5c5999fba216d36fb92c9),
via command line so as to provide proper commit author attribution to
@wolfy1961 (as this doesn't seem to be possible vi
Author: Wolfgang Pieb
Date: 2025-01-28T12:30:31Z
New Revision: 4424c44c8c4ec8e071f5c5999fba216d36fb92c9
URL:
https://github.com/llvm/llvm-project/commit/4424c44c8c4ec8e071f5c5999fba216d36fb92c9
DIFF:
https://github.com/llvm/llvm-project/commit/4424c44c8c4ec8e071f5c5999fba216d36fb92c9.diff
LOG:
SLTozer wrote:
Merged in
[71ab44a8](https://github.com/llvm/llvm-project/commit/71ab44a8193c56e4ef9aede4d9bac8e14760c6c6),
via command line so as to provide proper commit author attribution to
@wolfy1961 (as this doesn't seem to be possible via the web interface).
https://github.com/llvm/llvm
https://github.com/SLTozer closed
https://github.com/llvm/llvm-project/pull/11
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Wolfgang Pieb
Date: 2025-01-28T10:08:02Z
New Revision: 71ab44a8193c56e4ef9aede4d9bac8e14760c6c6
URL:
https://github.com/llvm/llvm-project/commit/71ab44a8193c56e4ef9aede4d9bac8e14760c6c6
DIFF:
https://github.com/llvm/llvm-project/commit/71ab44a8193c56e4ef9aede4d9bac8e14760c6c6.diff
LOG:
@@ -412,6 +412,20 @@ New Compiler Flags
only for thread-local variables, and none (which corresponds to the
existing ``-fno-c++-static-destructors`` flag) skips all static
destructors registration.
+- The ``-fextend-variable-liveness`` flag has been added to allow for imp
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/11
>From 6a873f5c487a936344f6cd226b7d525b406f34b2 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 25 Sep 2024 15:08:39 +0100
Subject: [PATCH 1/9] [Clang] Add "extend lifetime" flags and release note
Follow
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/110102
>From fdfa695bc74847f5cc366bfcbf142bd5c2e3937f Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 25 Sep 2024 16:55:39 +0100
Subject: [PATCH 1/6] [Clang] Add fake use emission to Clang with
-fextend-lifeti
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/110102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3595,15 +3595,26 @@ static llvm::StoreInst
*findDominatingStoreToReturnValue(CodeGenFunction &CGF) {
llvm::BasicBlock *IP = CGF.Builder.GetInsertBlock();
if (IP->empty()) return nullptr;
-// Look at directly preceding instruction, skipping bitcasts and lifetim
SLTozer wrote:
Ping
https://github.com/llvm/llvm-project/pull/110102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/123737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -173,8 +173,9 @@ Value *SSAUpdater::GetValueInMiddleOfBlock(BasicBlock *BB) {
// Set the DebugLoc of the inserted PHI, if available.
DebugLoc DL;
- if (const Instruction *I = BB->getFirstNonPHI())
- DL = I->getDebugLoc();
+ BasicBlock::iterator It = BB->getFirstN
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/123737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer approved this pull request.
Code changes LGTM. Regarding the direction of the patch, it seems a little
unfortunate to completely remove `getFirstNonPHI()` - sometimes we want the
instruction and sometimes we want the iterator, and forcing all of them to go
through `g
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/123737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -412,6 +412,20 @@ New Compiler Flags
only for thread-local variables, and none (which corresponds to the
existing ``-fno-c++-static-destructors`` flag) skips all static
destructors registration.
+- The ``-fextend-variable-liveness`` flag has been added to allow for imp
SLTozer wrote:
Post-holiday ping; I think all the outstanding comments have been addressed,
with some minor changes since the last round of review - primarily referencing
the new CodeGenOpts settings, and removing the O0-related logic.
https://github.com/llvm/llvm-project/pull/110102
_
SLTozer wrote:
Post-holiday ping - I believe all the comments have been addressed now, does
the new form look acceptable?
https://github.com/llvm/llvm-project/pull/11
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
SLTozer wrote:
I've updated this patch, and made it dependent on a [previous
PR](https://github.com/llvm/llvm-project/pull/11) - the logic for enabling
the flag is coupled with code from the earlier PR, and also we now slightly
extend the test added in that PR instead of creating a new one
@@ -1834,6 +1834,14 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
Opts.setInlining(CodeGenOptions::NormalInlining);
}
+ // If we have specified -Og and have not explicitly set
-fno-extend-lifetimes,
+ // then default to -fextend-li
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/118026
>From efd7f58e421b0afdc886688128f72170e0c4a970 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 25 Sep 2024 15:08:39 +0100
Subject: [PATCH 1/2] [Clang] Add "extend lifetime" flags and release note
Follow
SLTozer wrote:
I've removed the logic that disables this flag at O0 - this has also removed
the need for `-disable-O0-optnone` in any tests. Following the prior patch
updating this flag to be an `=` flag represented by an enum, the latest commit
changes this patch to handle that type. Finally,
SLTozer wrote:
I've added a test for this patch that tests the driver - since we will now be
relying on the driver to decide whether to pass these flags to the frontend,
rather than trivially always doing so (so that [later
on](https://github.com/llvm/llvm-project/pull/118026) we can use the d
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/110102
>From fdfa695bc74847f5cc366bfcbf142bd5c2e3937f Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 25 Sep 2024 16:55:39 +0100
Subject: [PATCH 1/5] [Clang] Add fake use emission to Clang with
-fextend-lifeti
https://github.com/SLTozer updated
https://github.com/llvm/llvm-project/pull/11
>From 6a873f5c487a936344f6cd226b7d525b406f34b2 Mon Sep 17 00:00:00 2001
From: Stephen Tozer
Date: Wed, 25 Sep 2024 15:08:39 +0100
Subject: [PATCH 1/7] [Clang] Add "extend lifetime" flags and release note
Follow
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/110102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 233 matches
Mail list logo
