[clang] [llvm] [IndVarSimplify] Sink unused l-invariant loads in preheader. (PR #157559)

2025-09-12 Thread Sirish Pande via cfe-commits
@@ -1100,14 +1112,32 @@ bool IndVarSimplify::sinkUnusedInvariants(Loop *L) { break; // Don't move instructions which might have side effects, since the side -// effects need to complete before instructions inside the loop. Also don't -// move instructions w

[clang] [llvm] [IndVarSimplify] Sink unused l-invariant loads in preheader. (PR #157559)

2025-09-12 Thread Sirish Pande via cfe-commits
@@ -30,3 +30,64 @@ loop: exit: ret i32 %add } + srpande wrote: Please add at least one (two is better) test with noalias & alias_info metadata for loads and stores; and show whether load will sink or not depending on metadata. I would also write these tes

[clang] [llvm] AMDGPU: Add v_mfma_f32_16x16x32_bf16 for gfx950 (PR #117053)

2024-11-21 Thread Sirish Pande via cfe-commits
https://github.com/srpande approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/117053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] AMDGPU: Simplify EmitAMDGPUBuiltinExpr for load transposes, NFC (PR #86707)

2024-03-26 Thread Sirish Pande via cfe-commits
https://github.com/srpande approved this pull request. It's a good change. https://github.com/llvm/llvm-project/pull/86707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Rename intrinsics and remove f16/bf16 versions for load transpose (PR #86313)

2024-03-25 Thread Sirish Pande via cfe-commits
https://github.com/srpande approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/86313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Rename intrinsics and remove f16/bf16 versions for load transpose (PR #86313)

2024-03-25 Thread Sirish Pande via cfe-commits
@@ -18533,51 +18533,35 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, } case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_i32: case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_v2i32: - case AMDGPU::BI__builtin_amdgcn_global_load_tr_b128_v4bf16:

[clang] [llvm] AMDGPU: Rename intrinsics and remove f16/bf16 versions for load transpose (PR #86313)

2024-03-22 Thread Sirish Pande via cfe-commits
srpande wrote: There is no issue in changing the names in principle. Curious, what is the rationale to use more demangled names? https://github.com/llvm/llvm-project/pull/86313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang-tools-extra] [AMDGPU] Use 32-bit SGPR to save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande edited https://github.com/llvm/llvm-project/pull/68367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Use 32-bit SGPR to save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande edited https://github.com/llvm/llvm-project/pull/68367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AMDGPU] Use 32-bit SGPR o save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande edited https://github.com/llvm/llvm-project/pull/68367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Use 32-bit SGPR o save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande edited https://github.com/llvm/llvm-project/pull/68367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AMDGPU] Use 32-bit SGPR during save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande updated https://github.com/llvm/llvm-project/pull/68367 >From a76a360c1d7fa0860944b6bfcb65ab3405c7b4c6 Mon Sep 17 00:00:00 2001 From: Sirish Pande Date: Thu, 28 Sep 2023 11:39:32 -0500 Subject: [PATCH 1/2] [AMDGPU] Save/Restore SCC bit across waterfall loop. Waterfal

[clang] [AMDGPU] Use 32-bit SGPR during save/restore of SCC (PR #68367)

2023-10-10 Thread Sirish Pande via cfe-commits
https://github.com/srpande updated https://github.com/llvm/llvm-project/pull/68367 >From a76a360c1d7fa0860944b6bfcb65ab3405c7b4c6 Mon Sep 17 00:00:00 2001 From: Sirish Pande Date: Thu, 28 Sep 2023 11:39:32 -0500 Subject: [PATCH 1/2] [AMDGPU] Save/Restore SCC bit across waterfall loop. Waterfal

[clang] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-21 Thread Sirish Pande via cfe-commits
https://github.com/srpande closed https://github.com/llvm/llvm-project/pull/66701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-21 Thread Sirish Pande via cfe-commits
https://github.com/srpande closed https://github.com/llvm/llvm-project/pull/66701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-20 Thread Sirish Pande via cfe-commits
https://github.com/srpande updated https://github.com/llvm/llvm-project/pull/66701 >From a9fe01d82743879c41982aa170fef517dee99256 Mon Sep 17 00:00:00 2001 From: Sirish Pande Date: Fri, 15 Sep 2023 13:01:09 -0500 Subject: [PATCH] [SelectionDAG] Flags are dropped when creating a new FMUL While s

[clang-tools-extra] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-20 Thread Sirish Pande via cfe-commits
https://github.com/srpande updated https://github.com/llvm/llvm-project/pull/66701 >From a9fe01d82743879c41982aa170fef517dee99256 Mon Sep 17 00:00:00 2001 From: Sirish Pande Date: Fri, 15 Sep 2023 13:01:09 -0500 Subject: [PATCH] [SelectionDAG] Flags are dropped when creating a new FMUL While s