[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc added a comment. Made suggested changes, ready for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 ___ cfe-commits mailing l

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389334. sheldonneuberger-sc added a comment. - revert whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389333. sheldonneuberger-sc added a comment. - inline test helper for readability - fix indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files:

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc added a comment. Thanks for the detailed comments. I moved the patch into the clangd callsite. I also added a couple ObjC tests for CallHierarchy (I basically parameterized two of the existing tests). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388101. sheldonneuberger-sc added a comment. - fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388100. sheldonneuberger-sc added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388099. sheldonneuberger-sc added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. - move change to clangd callsite - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc created this revision. sheldonneuberger-sc added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet. sheldonneuberger-sc added a reviewer: erichkeane. sheldonneuberger-sc edited the summary of this revision. sheldonneuberger-sc published this revision for review.