[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo added a comment. I don't have commit access yet. Would you mind to commit it for me? Thanks!, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 ___ cfe-commits mai

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180844. smateo added a comment. Done! Thanks, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180792. smateo added a comment. Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180631. smateo added a comment. Adding more context Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo created this revision. smateo added a reviewer: ABataev. smateo added a project: OpenMP. Herald added a subscriber: cfe-commits. There is a minor issue in how the implicit data-sharings for nested tasks are computed. For the following example: int x; #pragma omp task shared(x) #pra

[PATCH] D53636: Do not always request an implicit taskgroup region inside the kmpc_taskloop function

smateo added a comment. Hi Alexey, Thanks for the prompt review! I don't have commit access yet, do you mind to commit it for me? Thanks! Repository: rC Clang https://reviews.llvm.org/D53636 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D53636: Do not always request an implicit taskgroup region inside the kmpc_taskloop function

smateo created this revision. smateo added a reviewer: ABataev. Herald added a subscriber: cfe-commits. For the following code: int i; #pragma omp taskloop for (i = 0; i < 100; ++i) {} #pragma omp taskloop nogroup for (i = 0; i < 100; ++i) {} Clang emits the following LLVM IR: